From: Willy TARREAU <willy@w.ods.org>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: linux-kernel@vger.kernel.org, netfilter-devel@lists.netfilter.org
Subject: [PATCH-2.4.26] ip6tables cleanup
Date: Sun, 28 Mar 2004 13:54:39 +0200 [thread overview]
Message-ID: <20040328115439.GA24421@pcw.home.local> (raw)
In-Reply-To: <20040328042608.GA17969@logos.cnet>
Hi Marcelo, all
2.4.26-rc1 returned this warning compiling ip6_tables :
ip6_tables.c: In function `tcp_match':
ip6_tables.c:1596: warning: implicit declaration of function `ipv6_skip_exthdr'
I had to add a cast because ipv6_skip_exthdr() expects a 'struct sk_buff*' while
its caller uses a 'const struct sk_buff*'. Here is a cleanup patch.
Please apply,
Willy
--- ./net/ipv6/netfilter/ip6_tables.c.orig Sun Mar 28 10:57:08 2004
+++ ./net/ipv6/netfilter/ip6_tables.c Sun Mar 28 11:15:55 2004
@@ -23,7 +23,7 @@
#include <asm/uaccess.h>
#include <asm/semaphore.h>
#include <linux/proc_fs.h>
-
+#include <net/ipv6.h>
#include <linux/netfilter_ipv6/ip6_tables.h>
#define IPV6_HDR_LEN (sizeof(struct ipv6hdr))
@@ -1593,7 +1593,8 @@
}
tcpoff = (u8*)(skb->nh.ipv6h + 1) - skb->data;
- tcpoff = ipv6_skip_exthdr(skb, tcpoff, &nexthdr, skb->len - tcpoff);
+ tcpoff = ipv6_skip_exthdr((struct sk_buff *)skb,
+ tcpoff, &nexthdr, skb->len - tcpoff);
if (tcpoff < 0 || tcpoff > skb->len) {
duprintf("tcp_match: cannot skip exthdr. Dropping.\n");
*hotdrop = 1;
@@ -1674,7 +1675,8 @@
}
udpoff = (u8*)(skb->nh.ipv6h + 1) - skb->data;
- udpoff = ipv6_skip_exthdr(skb, udpoff, &nexthdr, skb->len - udpoff);
+ udpoff = ipv6_skip_exthdr((struct sk_buff *)skb,
+ udpoff, &nexthdr, skb->len - udpoff);
if (udpoff < 0 || udpoff > skb->len) {
duprintf("udp_match: cannot skip exthdr. Dropping.\n");
*hotdrop = 1;
next prev parent reply other threads:[~2004-03-28 11:54 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-28 4:26 Linux 2.4.26-rc1 Marcelo Tosatti
2004-03-28 11:47 ` Willy TARREAU
2004-03-28 11:54 ` Willy TARREAU [this message]
2004-03-28 19:27 ` [PATCH-2.4.26] ip6tables cleanup Peter Osterlund
2004-03-28 20:09 ` Willy TARREAU
2004-03-28 20:33 ` David S. Miller
2004-03-28 22:38 ` Willy TARREAU
2004-03-28 23:00 ` David S. Miller
2004-03-28 20:16 ` David S. Miller
2004-03-28 11:57 ` [PATCH-2.4.26] cmpci cleanup Willy TARREAU
2004-03-29 12:19 ` Marcelo Tosatti
2004-03-28 12:12 ` [PATCH-2.4.26] smbfs cleanup Willy TARREAU
2004-03-28 12:15 ` [PATCH-2.4.26] sddr09 cleanup Willy TARREAU
2004-03-28 12:18 ` Willy TARREAU
2004-03-28 12:21 ` [PATCH-2.4.26] drm/radeon_mem cleanup Willy TARREAU
2004-03-28 12:24 ` [PATCH-2.4.26] cardbus cleanup Willy TARREAU
2004-03-28 12:40 ` Linux 2.4.26-rc1 => Alpha warnings Willy TARREAU
2004-03-28 16:34 ` Ivan Kokshaysky
2004-03-28 12:58 ` [PATCH-2.4.26] ATM cleanup Willy TARREAU
2004-03-28 13:03 ` Chris Wedgwood
2004-03-28 13:08 ` Willy TARREAU
2004-03-30 17:44 ` chas williams (contractor)
2004-03-31 3:18 ` David S. Miller
2004-03-28 13:38 ` [PATCH-2.4.26] AGPGART cleanup Willy TARREAU
2004-03-28 15:24 ` Linux 2.4.26-rc1 Arkadiusz Miskiewicz
2004-03-28 19:11 ` Peter Osterlund
2004-03-28 20:41 ` Frédéric L. W. Meunier
2004-04-01 0:47 ` Linux 2.4.26-rc1 - SCTP 'make xconfig' issue Sridhar Samudrala
2004-04-01 5:24 ` Peter Osterlund
2004-04-01 7:05 ` David S. Miller
2004-04-01 7:29 ` Sridhar Samudrala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040328115439.GA24421@pcw.home.local \
--to=willy@w.ods.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®