From: Andrew Morton <akpm@osdl.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ppc32: Fix sector_t definition with CONFIG_LBD
Date: Sun, 28 Mar 2004 23:03:51 -0800 [thread overview]
Message-ID: <20040328230351.1a0d0e9c.akpm@osdl.org> (raw)
In-Reply-To: <1080541934.1210.5.camel@gaston>
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> sector_t depends on CONFIG_LBD but include/config.h may not be there
> thus causing interesting breakage in some places...
Nasty.
> Here's the fix for ppc32 (problem found by Roman Zippel, other archs
> need a similar fix).
Three of them.
25-akpm/include/asm-s390/types.h | 2 ++
25-akpm/include/asm-sh/types.h | 2 ++
25-akpm/include/asm-x86_64/types.h | 2 ++
3 files changed, 6 insertions(+)
diff -puN include/asm-s390/types.h~types_h-needs-config_h include/asm-s390/types.h
--- 25/include/asm-s390/types.h~types_h-needs-config_h 2004-03-28 23:02:57.481365480 -0800
+++ 25-akpm/include/asm-s390/types.h 2004-03-28 23:02:57.486364720 -0800
@@ -50,6 +50,8 @@ typedef __signed__ long saddr_t;
*/
#ifdef __KERNEL__
+#include <linux/config.h>
+
#ifndef __s390x__
#define BITS_PER_LONG 32
#else
diff -puN include/asm-sh/types.h~types_h-needs-config_h include/asm-sh/types.h
--- 25/include/asm-sh/types.h~types_h-needs-config_h 2004-03-28 23:02:57.482365328 -0800
+++ 25-akpm/include/asm-sh/types.h 2004-03-28 23:02:57.486364720 -0800
@@ -31,6 +31,8 @@ typedef unsigned long long __u64;
*/
#ifdef __KERNEL__
+#include <linux/config.h>
+
#define BITS_PER_LONG 32
#ifndef __ASSEMBLY__
diff -puN include/asm-x86_64/types.h~types_h-needs-config_h include/asm-x86_64/types.h
--- 25/include/asm-x86_64/types.h~types_h-needs-config_h 2004-03-28 23:02:57.484365024 -0800
+++ 25-akpm/include/asm-x86_64/types.h 2004-03-28 23:02:57.486364720 -0800
@@ -29,6 +29,8 @@ typedef unsigned long long __u64;
*/
#ifdef __KERNEL__
+#include <linux/config.h>
+
#define BITS_PER_LONG 64
#ifndef __ASSEMBLY__
_
next prev parent reply other threads:[~2004-03-29 7:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-29 6:32 Benjamin Herrenschmidt
2004-03-29 7:03 ` Andrew Morton [this message]
[not found] ` <20040328230351.1a0d0e9c.akpm@osdl.org.suse.lists.linux.kernel>
2004-03-29 8:08 ` Andi Kleen
2004-03-29 9:37 ` [PATCH] small change to fget() Eric Dumazet
2004-03-29 13:18 ` [PATCH] ppc32: Fix sector_t definition with CONFIG_LBD Benjamin Herrenschmidt
2004-03-29 10:00 ` Andi Kleen
2004-03-29 13:10 ` Anton Blanchard
2004-03-29 13:19 ` Christoph Hellwig
2004-03-29 19:02 Michel Roelofs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040328230351.1a0d0e9c.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®