From: Petr Vandrovec <vandrove@vc.cvut.cz>
To: Pavel Machek <pavel@ucw.cz>
Cc: Hans-Peter Jansen <hpj@urpla.net>, linux-kernel@vger.kernel.org
Subject: Re: VMware-workstation-4.5.1 on linux-2.6.4-x86_64 host fai
Date: Tue, 30 Mar 2004 23:44:22 +0200 [thread overview]
Message-ID: <20040330214422.GH22319@vana.vc.cvut.cz> (raw)
In-Reply-To: <20040330123331.GB461@elf.ucw.cz>
On Tue, Mar 30, 2004 at 02:33:31PM +0200, Pavel Machek wrote:
> Hi!
>
> > Hmm, it's a SuSE issue then, nice to know (and easily fixable ;-).
> >
> > > On 2.6.x kernels additionally (problem you are hitting now)
> > > SIO*BRIDGE ioctls were moved from "compatible" to "not so
> > > compatible" group. If you'll just mark them as "compatible", it
> > > will work sufficiently well to get networking in VMware.
> >
> > I found it. Fixed it with this patch:
> >
> > --- include/linux/compat_ioctl.h~ 2004-03-12 18:37:26.000000000 +0100
> > +++ include/linux/compat_ioctl.h 2004-03-24 12:34:30.000000000 +0100
> > @@ -247,10 +247,10 @@
> > COMPATIBLE_IOCTL(SIOCSIFENCAP)
> > COMPATIBLE_IOCTL(SIOCGIFENCAP)
> > COMPATIBLE_IOCTL(SIOCSIFNAME)
> > -/* FIXME: not compatible
> > +/* FIXME: not compatible */
> > COMPATIBLE_IOCTL(SIOCSIFBR)
> > COMPATIBLE_IOCTL(SIOCGIFBR)
> > -*/
> > +/* reactivated for vmware */
> > COMPATIBLE_IOCTL(SIOCSARP)
> > COMPATIBLE_IOCTL(SIOCGARP)
> > COMPATIBLE_IOCTL(SIOCDARP)
>
> Marking ioctl compatible when it is not is pretty nasty, right? What
> about writing conversion functions?
Well, main problem is that VMware uses SIOCSIFBR and SIOCGIFBR with completely
different semantic than everybody else, and for VMware identical translation
is correct for SIOCSIFBR. SIOCGIFBR (for which identical translation is
not correct) does not appear to be used at all.
I'll fill bugreport with VMware. For existing systems correct solution is:
(1a) Mark SIOCSIFBR as COMPATIBLE_IOCTL.
(1b) No change is needed for SIOCGIFBR.
(2) Your bridge control tools must be 64bit app. As they'll not run when built
as 32bit app anyway, no big damage is caused here...
Best regards,
Petr Vandrovec
prev parent reply other threads:[~2004-03-30 21:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-24 11:59 Petr Vandrovec
2004-03-24 18:55 ` Hans-Peter Jansen
2004-03-30 12:33 ` Pavel Machek
2004-03-30 21:17 ` Hans-Peter Jansen
2004-03-30 21:44 ` Petr Vandrovec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040330214422.GH22319@vana.vc.cvut.cz \
--to=vandrove@vc.cvut.cz \
--cc=hpj@urpla.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®