mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adam Nielsen <a.nielsen@optushome.com.au>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@osdl.org>
Subject: [PATCH] Fix kernel lockup in RTL-8169 gigabit ethernet driver
Date: Sat, 3 Apr 2004 15:02:29 +1000	[thread overview]
Message-ID: <20040403150229.75ec6b98.a.nielsen@optushome.com.au> (raw)

Hi everyone,

This is a tiny patch that fixes a particularly annoying bug
in the Realtek 8169 gigabit ethernet driver.  Due to a logic error,
there is a loop in an interrupt handler that often goes infinite, thus
locking up the entire computer.  The attached patch fixes the problem.

I have patched against linux-2.6.5-rc2-bk6, however the source file in
question hasn't been modified for a long time, so the patch should apply
cleanly to any recent kernel version.

Cheers,
Adam.

--- linux-2.6.5-rc2-bk6/drivers/net/r8169.c	2004-03-27 17:38:03.000000000 +1000
+++ linux-2.6.5-rc2-bk6a/drivers/net/r8169.c	2004-03-31 18:45:10.000000000 +1000
@@ -33,6 +33,12 @@
 	- Copy mc_filter setup code from 8139cp
 	  (includes an optimization, and avoids set_bit use)
 
+VERSION 1.2a <2004/03/31> Adam Nielsen (a.nielsen@optushome.com.au)
+
+	"else break;" added to the if-statement in rtl8169_tx_interrupt() to prevent
+	an infinite loop and the resulting kernel lockup when the interrupt is called
+	with a dirty buffer (perhaps when there's nothing to transmit?)
+
 */
 
 #include <linux/module.h>
@@ -892,7 +898,7 @@
 			tp->Tx_skbuff[entry] = NULL;
 			dirty_tx++;
 			tx_left--;
-		}
+		} else break;
 	}
 
 	if (tp->dirty_tx != dirty_tx) {

             reply	other threads:[~2004-04-03  4:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-03  5:02 Adam Nielsen [this message]
2004-04-03  9:27 ` Francois Romieu
2004-04-03 10:07   ` Andrew Morton
2004-04-03 12:13     ` Francois Romieu
2004-04-03 11:30 Manfred Spraul
2004-04-03 12:45 ` Francois Romieu
2004-04-04  0:55 ` Malvineous
2004-04-04  9:15   ` Francois Romieu
2004-04-05 21:51     ` Adam Nielsen
2004-04-06 17:11       ` Manfred Spraul
2004-04-06 20:50         ` Francois Romieu
2004-04-05 23:08 Dieter Nützel
2004-04-06  7:47 ` Francois Romieu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040403150229.75ec6b98.a.nielsen@optushome.com.au \
    --to=a.nielsen@optushome.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®