Re: [PATCH][2.6-mm] early_param console_setup clobbers commandline

[Tom Rini <trini@kernel.crashing.org>]

On Sat, Apr 03, 2004 at 10:40:01AM -0500, Zwane Mwaikambo wrote:

> On Fri, 2 Apr 2004, Tom Rini wrote:
> 
> > This shouldn't be a problem 'tho, since we don't allow for spaces in
> > args, and we do find where the next space is, and ensure it's still a
> > space after the call (because console can splice up the command line,
> > but we'd skip over those bits anyhow).
> 
> Another new thing is that all setup functions get called with their
> parameter and any other trailing arguments. So console_setup sees;
> 
> tty0 console=ttyS0,38400 hugepages=20 nmi_watchdog=2
> 
> That's different enough to cause potential problems in future.

I _thought_ I had put in bits to make it only pass along the argument,
but perhaps that got lost in my testing/retesting.

> > pci= will clobber as well, which is why I thought I asked Andrew to drop
> > that part of the i386 patch (but perhaps I forgot, and with Rusty's
> > patch, it becomes a non-issue again).
> 
> What is the patch name for Rusty's patch?

I don't know, since I think once he got it working he forgot to CC lkml.
But I certainly hope it's in the next -mm since it replaced the
parse_early_options parsing code with parse_args, so all of the stupid
things my re-implementation got wrong, it doesn't.

-- 
Tom Rini
http://gate.crashing.org/~trini/