Re: [linux-usb-devel] [PATCH] (linux 2.4.25) hangup on disconnect for usbserial module

[Pete Zaitcev <zaitcev@redhat.com>]

On Sun, 4 Apr 2004 21:46:52 -0700
"Robert White" <rwhite@casabyte.com> wrote:

> This is "reasonably well tested" on the x86 platform.
> 
> This patch fixes a problem where the usbserial code would not notify
> connected programs that the serial port was going away.

> @@ -1404,9 +1408,11 @@ static void usb_serial_disconnect(struct
>                 for (i = 0; i < serial->num_ports; ++i) {
>                         port = &serial->port[i];
>                         down (&port->sem);
> -                       if (port->tty != NULL)
> +                       if (port->tty != NULL) {
> +                               tty_hangup(port->tty);
>                                 while (port->open_count > 0)
>                                         __serial_close(port, NULL);
> +                       }

I'll think about it.

If Greg approves and takes, it's fine, too.

What is the actual symptom? Did you expect a SIGHUP?

-- Pete