mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.5-mc2
Date: Wed, 7 Apr 2004 11:27:38 -0700	[thread overview]
Message-ID: <20040407112738.23d07088.akpm@osdl.org> (raw)
In-Reply-To: <20040407180919.GB30117@holomorphy.com>

William Lee Irwin III <wli@holomorphy.com> wrote:
>
> On Wed, Apr 07, 2004 at 11:04:30AM -0700, William Lee Irwin III wrote:
> > +	if (sizeof(unsigned long) == 8)
> 
> Ugh.

I did it this way, relying on magical promotions:

--- 25/fs/open.c~nfs-32bit-statfs-fix-warning-fix	2004-04-06 23:16:25.221685072 -0700
+++ 25-akpm/fs/open.c	2004-04-06 23:16:25.225684464 -0700
@@ -64,10 +64,10 @@ static int vfs_statfs_native(struct supe
 			 * f_files and f_ffree may be -1; it's okay to stuff
 			 * that into 32 bits
 			 */
-			if (st.f_files != 0xffffffffffffffffULL &&
+			if (st.f_files != -1 &&
 			    (st.f_files & 0xffffffff00000000ULL))
 				return -EOVERFLOW;
-			if (st.f_ffree != 0xffffffffffffffffULL &&
+			if (st.f_ffree != -1 &&
 			    (st.f_ffree & 0xffffffff00000000ULL))
 				return -EOVERFLOW;
 		}

_


  reply	other threads:[~2004-04-07 18:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-07  5:17 2.6.5-mc2 Andrew Morton
2004-04-07 15:29 ` 2.6.5-mc2 (compile stats) John Cherry
2004-04-07 16:12   ` John Cherry
2004-04-07 16:06 ` 2.6.5-mc2 Gerd Knorr
2004-04-07 18:04 ` 2.6.5-mc2 William Lee Irwin III
2004-04-07 18:09   ` 2.6.5-mc2 William Lee Irwin III
2004-04-07 18:27     ` Andrew Morton [this message]
2004-04-07 18:34       ` 2.6.5-mc2 William Lee Irwin III
2004-04-07 18:52         ` 2.6.5-mc2 Andrew Morton
2004-04-07 19:27           ` 2.6.5-mc2 William Lee Irwin III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040407112738.23d07088.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®