mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: linux-kernel@vger.kernel.org, Nick.Holloway@pyrites.org.uk
Subject: Re: [PATCH 2.6] Add missing MODULE_PARAM to dummy.c (and MAINTAINERShip)
Date: Thu, 8 Apr 2004 10:54:40 -0700	[thread overview]
Message-ID: <20040408105440.G22989@build.pdx.osdl.net> (raw)
In-Reply-To: <20040408174823.GA13335@localhost>; from linux-kernel@24x7linux.com on Thu, Apr 08, 2004 at 07:48:23PM +0200

* Jose Luis Domingo Lopez (linux-kernel@24x7linux.com) wrote:
> diff -Nrup linux-2.6.5/drivers/net/dummy.c linux-2.6.5-new/drivers/net/dummy.c
> --- linux-2.6.5/drivers/net/dummy.c	2004-04-04 17:45:54.000000000 +0200
> +++ linux-2.6.5-new/drivers/net/dummy.c	2004-04-08 19:23:23.000000000 +0200
> @@ -89,7 +89,8 @@ static struct net_device_stats *dummy_ge
>  static struct net_device **dummies;
>  
>  /* Number of dummy devices to be set up by this module. */
> -module_param(numdummies, int, 0);
> +MODULE_PARM(numdummies, "i");
> +MODULE_PARM_DESC(numdummies, "Maximum number of dummy devices (defaults to one)");

this is going backwards.  module_param is the newer (preferred) interface.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net

  reply	other threads:[~2004-04-08 17:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-08 17:48 Jose Luis Domingo Lopez
2004-04-08 17:54 ` Chris Wright [this message]
2004-04-08 18:59   ` Jose Luis Domingo Lopez
2004-04-08 19:29     ` Chris Wright
2004-04-08 19:10 ` Nick Holloway

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040408105440.G22989@build.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=Nick.Holloway@pyrites.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®