From: Thorsten Kranzkowski <dl8bcu@dl8bcu.de>
To: Zwane Mwaikambo <zwane@linuxpower.ca>
Cc: linux-kernel@vger.kernel.org, rth@twiddle.net, spyro@f2s.com,
rmk@arm.linux.org.uk, davidm@hpl.hp.com, paulus@au.ibm.com,
benh@kernel.crashing.org, jes@trained-monkey.org, ralf@gnu.org,
matthew@wil.cx, davem@redhat.com, wesolows@foobazco.org,
jdike@karaya.com, ak@suse.de
Subject: Re: [PATCH][RFC] sort out CLOCK_TICK_RATE usage [0/3]
Date: Mon, 12 Apr 2004 20:11:57 +0000 [thread overview]
Message-ID: <20040412201156.B5625@Marvin.DL8BCU.ampr.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0404121246310.18930@montezuma.fsmlabs.com>; from zwane@linuxpower.ca on Mon, Apr 12, 2004 at 12:47:08PM -0400
On Mon, Apr 12, 2004 at 12:47:08PM -0400, Zwane Mwaikambo wrote:
> On Mon, 12 Apr 2004, Thorsten Kranzkowski wrote:
>
> > With every 2.6 kernel I tried the system speaker on my Alpha produces a
> > rather unpleasant high pitched tone instead of the normal system beep.
> > This is because in p|cspkr.c the calculation of the counter values is
> > incorrectly based on CLOCK_TICK_RATE.
> > To solve this problem I came up with these tree patches:
> >
> > 1/3: introduce PIC_TICK_RATE constant. It seems this is not always
> > the same value.
> > 2/3: use PIC_TICK_RATE in *spkr.c and some other places where the
> > PIC is directly programmed.
> > 3/3: use CLOCK_TICK_RATE where 1193180 was used in timing calculations.
> >
> > Tested on Alpha, compile & boot-tested on i386 (unrelated LVM problems here)
> >
> > Arch maintainers please have a look whether I got the constants right or
> > if your architecture has a PIC at all.
>
> Isn't this supposed to be PIT_TICK_RATE?
I reused the define in arch/alpha/kernel/time.c that served exactly
the same purpose. I have no problems to call this a timer instead
of a counter, though. :)
Bye,
Thorsten
--
| Thorsten Kranzkowski Internet: dl8bcu@dl8bcu.de |
| Mobile: ++49 170 1876134 Snail: Kiebitzstr. 14, 49324 Melle, Germany |
| Ampr: dl8bcu@db0lj.#rpl.deu.eu, dl8bcu@marvin.dl8bcu.ampr.org [44.130.8.19] |
next prev parent reply other threads:[~2004-04-12 20:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-12 7:55 Thorsten Kranzkowski
2004-04-12 7:57 ` [PATCH][RFC] sort out CLOCK_TICK_RATE usage [1/3] Thorsten Kranzkowski
2004-04-12 7:57 ` [PATCH][RFC] sort out CLOCK_TICK_RATE usage [2/3] Thorsten Kranzkowski
2004-04-12 7:58 ` [PATCH][RFC] sort out CLOCK_TICK_RATE usage [3/3] Thorsten Kranzkowski
2004-04-12 16:39 ` [PATCH][RFC] sort out CLOCK_TICK_RATE usage [1/3] David Mosberger
2004-04-12 20:08 ` Thorsten Kranzkowski
2004-04-12 20:32 ` David Mosberger
2004-04-12 21:17 ` Thorsten Kranzkowski
2004-04-13 4:04 ` Miles Bader
2004-04-13 17:00 ` Thorsten Kranzkowski
2004-04-14 1:45 ` Miles Bader
2004-04-12 16:47 ` [PATCH][RFC] sort out CLOCK_TICK_RATE usage [0/3] Zwane Mwaikambo
2004-04-12 20:11 ` Thorsten Kranzkowski [this message]
2004-04-12 20:50 ` Zwane Mwaikambo
2004-04-13 21:58 ` [PATCH] sort out CLOCK_TICK_RATE usage, 2nd try [0/3] Thorsten Kranzkowski
2004-04-13 21:59 ` [PATCH] sort out CLOCK_TICK_RATE usage, 2nd try [1/3] Thorsten Kranzkowski
2004-04-13 22:01 ` [PATCH] sort out CLOCK_TICK_RATE usage, 2nd try [2/3] Thorsten Kranzkowski
2004-04-13 22:02 ` [PATCH] sort out CLOCK_TICK_RATE usage, 2nd try [3/3] Thorsten Kranzkowski
2004-04-13 22:39 ` Randy.Dunlap
2004-04-14 14:12 ` [PATCH] sort out CLOCK_TICK_RATE usage, 2nd try [0/3] Matthew Wilcox
2004-04-16 9:05 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040412201156.B5625@Marvin.DL8BCU.ampr.org \
--to=dl8bcu@dl8bcu.de \
--cc=ak@suse.de \
--cc=benh@kernel.crashing.org \
--cc=davem@redhat.com \
--cc=davidm@hpl.hp.com \
--cc=jdike@karaya.com \
--cc=jes@trained-monkey.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=paulus@au.ibm.com \
--cc=ralf@gnu.org \
--cc=rmk@arm.linux.org.uk \
--cc=rth@twiddle.net \
--cc=spyro@f2s.com \
--cc=wesolows@foobazco.org \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®