From: Don Koch <aardvark@krl.com>
To: John Cherry <cherry@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: IA32 (2.6.5 - 2004-04-12.22.30) - 2 New warnings (gcc 3.2.2)
Date: Tue, 13 Apr 2004 14:11:46 -0400 [thread overview]
Message-ID: <200404131811.i3DIBkv8012367@p-chan.krl.com> (raw)
In-Reply-To: Message from John Cherry <cherry@osdl.org> of "Tue, 13 Apr 2004 07:31:38 PDT." <200404131431.i3DEVcCg010071@cherrypit.pdx.osdl.net>
> drivers/video/fbmem.c:914: warning: passing arg 1 of `copy_from_user' discards qualifiers from pointer target type
The following patch fixes the warning - the "data" field is "const"
for apparently varying definitions of the word "const" ;-).
===== fbmem.c 1.95 vs edited =====
--- 1.94/drivers/video/fbmem.c Thu Mar 25 12:57:01 2004
+++ edited/fbmem.c Tue Apr 13 13:17:56 2004
@@ -911,7 +911,7 @@
return -ENOMEM;
}
- if (copy_from_user(cursor.image.data, sprite->image.data, size) ||
+ if (copy_from_user((char *)cursor.image.data, sprite->image.data, size) ||
copy_from_user(cursor.mask, sprite->mask, size)) {
kfree(cursor.image.data);
kfree(cursor.mask);
prev parent reply other threads:[~2004-04-13 18:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-13 14:31 John Cherry
2004-04-13 15:37 ` Don Koch
2004-04-13 18:11 ` Don Koch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200404131811.i3DIBkv8012367@p-chan.krl.com \
--to=aardvark@krl.com \
--cc=cherry@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®