mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: Fabian Frederick <Fabian.Frederick@skynet.be>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.6.5-mm4] vfs_readdir optimizations
Date: Wed, 14 Apr 2004 13:15:59 -0700	[thread overview]
Message-ID: <20040414131559.R22989@build.pdx.osdl.net> (raw)
In-Reply-To: <1081972032.5445.30.camel@bluerhyme.real3>; from Fabian.Frederick@skynet.be on Wed, Apr 14, 2004 at 09:47:13PM +0200

* Fabian Frederick (Fabian.Frederick@skynet.be) wrote:
> -Remove unuseful gotos
> -ENOENT case on DEADDIR

Couple things.  It's useful to generate some numbers to show an
optimization is worthwhile.  And code readability/maintainability is
important to maintain correctness.  You may look at the assembly and
find that there is no real optimization with the changes you've proposed.

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net

      reply	other threads:[~2004-04-14 20:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-14 19:47 Fabian Frederick
2004-04-14 20:15 ` Chris Wright [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040414131559.R22989@build.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=Fabian.Frederick@skynet.be \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®