From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262422AbUDOIrx (ORCPT ); Thu, 15 Apr 2004 04:47:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263807AbUDOIrx (ORCPT ); Thu, 15 Apr 2004 04:47:53 -0400 Received: from postfix3-2.free.fr ([213.228.0.169]:20614 "EHLO postfix3-2.free.fr") by vger.kernel.org with ESMTP id S262422AbUDOIru (ORCPT ); Thu, 15 Apr 2004 04:47:50 -0400 From: Duncan Sands To: Oliver Neukum , Greg KH Subject: Re: [linux-usb-devel] [PATCH 7/9] USB usbfs: destroy submitted urbs only on the disconnected interface Date: Thu, 15 Apr 2004 10:47:48 +0200 User-Agent: KMail/1.5.4 Cc: linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Frederic Detienne References: <200404141245.37101.baldrick@free.fr> <200404151005.22143.baldrick@free.fr> <200404151031.19940.oliver@neukum.org> In-Reply-To: <200404151031.19940.oliver@neukum.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200404151047.48239.baldrick@free.fr> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > > Hi Oliver, I thought you meant that CONFIG_EMBEDDED made WARN_ON go away > > (or something like that). If you just mean that it is easy to redefine > > WARN_ON by hand, then all I can say is: it is also easy to redefine warn > > by hand! Anyway, I made you the following patch: > > Yes, but I don't trust gcc to optimise away the 'if' if you redefine > warn(). The "if" cannot be optimized away for the case in point, because it does something (clears the bit) if it passes the test. If I used WARN_ON then it would have to be WARN_ON(1) in the else branch of the if. > But there is another point. The embedded people deserve a single switch > to remove assertion checks. The purpose of macros like WARN_ON() is > easy and _central_ choice of debugging output vs. kernel size. This is not an argument against using USB's warn, it is an argument for building warn on top of a centralized macro like WARN_ON or a friend. All the best, Duncan.