On Friday 16 April 2004 07:03, Randy.Dunlap wrote:

Hi Randy,

> Use generic lib/Kconfig.debug and arch-specific arch/*/Kconfig.debug.
> Move KALLSYMS to generic debugging menu.
> Changes from version 1:
> 1.  remove global !CRIS && !H8300 from lib/Kconfig.debug;
> 2.  for CRIS and H8300, don't source lib/Kconfig.debug (not used);
> 3.  corrected several lib/Kconfig.debug ARCH usages;
> 4.  small change in generic debug menu order (moved SPINLOCK
> 	options together);
> Ready for testing IMO.  More comments?

yes. I'd like to see it this way:

Changes from version 2:
1.  Early Printk should not depend on EMBEDDED
2.  change "if foobar" to "depend on"
3.  remove endif's superfluous because of 2.
4.  Move KALLSYMS some places lower
5.  Add some more "depend on DEBUG_KERNEL" to indent the menu
6.  Remove trailing new lines in some arch specific Kconfig.debug
7.  move depends on DEBUG_KERNEL for arch/m68k/Kconfig.debug to
    the menu so you only see that menu if you select DEBUG_KERNEL
    You can't select anything there if DEBUG_KERNEL is N.
8.  Whitespace cleanups

Comments?


Everything else is fine with me.

All-in-One v3-proposed is here:
 http://www.kernel.org/pub/linux/kernel/people/mcp/linux-2.6/kconf-debug-v3-proposed-2.6.6-rc1.patch

Update from v2 to v3-proposed is here too:
 http://www.kernel.org/pub/linux/kernel/people/mcp/linux-2.6/kconf-debug-v2-to-v3-proposed-2.6.6-rc1.patch


ciao, Marc