mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Riesen <fork0@users.sourceforge.net>
To: Ulrich Drepper <drepper@redhat.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: POSIX message queues, libmqueue: mq_open, mq_unlink
Date: Fri, 16 Apr 2004 23:38:51 +0200	[thread overview]
Message-ID: <20040416213851.GA1784@steel.home> (raw)
In-Reply-To: <4080060F.7030604@redhat.com>

> > Looking over the code in libmqueue-4.31, I noticed the checks for the
> > name validity in the mq_open and mq_unlink. Why are they needed?  They
> > are pointless if the code in kernel depends on the valid name,
>
> You are contradicting yourself.
>
> Anyway, non-absolute path names passed to the functions mean the
> behavior is unspecified.  No portable application must ever do this.  It
> is enforced for this reason plus if there comes a time when we want to
> do something special which doesn't conflict with standard-compliant
> behavior we have a possibility for that.  Unlike wh6at you think, the
> tests *are* useful.

My concern is that the tests are rather pointing that something in
kernel is not implemented correctly. _The_ checks in particular.
Because if they _are_ implemented correctly, you don't need to patch the
functionality in the user space.

And if the kernel code does check the incoming arguments correctly,
what is the point to check them again? Just to make the point, that
passing in not an absolute path is not portable?



  reply	other threads:[~2004-04-16 21:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-16  8:11 Alex Riesen
2004-04-16 16:13 ` Ulrich Drepper
2004-04-16 21:38   ` Alex Riesen [this message]
2004-04-16 22:17     ` Ulrich Drepper
2004-04-16 22:22     ` Chris Wright
2004-04-16 23:43       ` Alex Riesen
2004-04-16 23:56         ` Chris Wright
2004-04-17  8:20           ` Alex Riesen
2004-04-17 10:49 Manfred Spraul
2004-04-17 11:16 ` Alex Riesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040416213851.GA1784@steel.home \
    --to=fork0@users.sourceforge.net \
    --cc=drepper@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®