From: Francois Romieu <romieu@fr.zoreil.com>
To: Dave Jones <davej@redhat.com>,
jgarzik@pobox.com, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: rcpci45 dereference fix.
Date: Fri, 16 Apr 2004 22:45:06 +0200 [thread overview]
Message-ID: <20040416224506.A2769@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20040416212342.GG25240@redhat.com>; from davej@redhat.com on Fri, Apr 16, 2004 at 10:23:42PM +0100
Dave Jones <davej@redhat.com> :
> --- linux-2.6.5/drivers/net/rcpci45.c~ 2004-04-16 22:22:22.000000000 +0100
> +++ linux-2.6.5/drivers/net/rcpci45.c 2004-04-16 22:23:01.000000000 +0100
> @@ -129,13 +129,14 @@
> rcpci45_remove_one (struct pci_dev *pdev)
> {
> struct net_device *dev = pci_get_drvdata (pdev);
> - PDPA pDpa = dev->priv;
> + PDPA pDpa;
>
> if (!dev) {
> printk (KERN_ERR "%s: remove non-existent device\n",
> dev->name);
> return;
> }
> + pDpa = dev->priv;
>
> RCResetIOP (dev);
> unregister_netdev (dev);
rcpci45_init_one() must succeed in order for rcpci45_remove_one() to be
issued.
If rcpci45_init_one() succeeds, dev can not be NULL.
So I'd rather see the "if (!dev) {" test removed instead of this change.
--
Ueimor
next prev parent reply other threads:[~2004-04-16 22:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-16 21:23 Dave Jones
2004-04-16 20:45 ` Francois Romieu [this message]
2004-04-16 21:50 ` Dave Jones
2004-04-19 16:40 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040416224506.A2769@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=davej@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®