From: Bill Nottingham <notting@redhat.com>
To: David Brownell <david-b@pacbell.net>
Cc: linux-kernel@vger.kernel.org, linux-usb-devel@lists.sourceforge.net
Subject: Re: [linux-usb-devel] oops when loading ehci_hcd
Date: Fri, 16 Apr 2004 23:08:56 -0400 [thread overview]
Message-ID: <20040417030856.GA3805@nostromo.devel.redhat.com> (raw)
In-Reply-To: <4080229B.4020307@pacbell.net>
David Brownell (david-b@pacbell.net) said:
> Looks like a cleanup path needs to handle early failure a bit better;
> likely just having ehci_stop test for ehci->async non-null (before
> calling scan-async to clean up any pending work) would suffice.
This patch solves the oops for me - thanks!
Bill
> --- 1.75/drivers/usb/host/ehci-hcd.c Wed Apr 14 20:20:58 2004
> +++ edited/drivers/usb/host/ehci-hcd.c Fri Apr 16 11:03:50 2004
> @@ -592,7 +592,8 @@
>
> /* root hub is shut down separately (first, when possible) */
> spin_lock_irq (&ehci->lock);
> - ehci_work (ehci, NULL);
> + if (ehci->async)
> + ehci_work (ehci, NULL);
> spin_unlock_irq (&ehci->lock);
> ehci_mem_cleanup (ehci);
>
prev parent reply other threads:[~2004-04-17 3:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-16 8:23 Bill Nottingham
2004-04-16 18:14 ` [linux-usb-devel] " David Brownell
2004-04-16 18:42 ` Bill Nottingham
2004-04-17 3:08 ` Bill Nottingham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040417030856.GA3805@nostromo.devel.redhat.com \
--to=notting@redhat.com \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®