From: Herbert Poetzl <herbert@13thfloor.at>
To: "David S. Miller" <davem@redhat.com>
Cc: Meelis Roos <mroos@linux.ee>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.5+BK compile error: binfmt_elf on sparc64
Date: Sat, 17 Apr 2004 05:29:12 +0200 [thread overview]
Message-ID: <20040417032912.GA23888@MAIL.13thfloor.at> (raw)
In-Reply-To: <20040414115301.37145997.davem@redhat.com>
On Wed, Apr 14, 2004 at 11:53:01AM -0700, David S. Miller wrote:
> On Wed, 14 Apr 2004 11:33:00 +0300 (EEST)
> Meelis Roos <mroos@linux.ee> wrote:
>
> > Because of -Werror, it bails out:
> >
> > In file included from arch/sparc64/kernel/binfmt_elf32.c:154:
> > fs/binfmt_elf.c: In function `load_elf_interp':
> > fs/binfmt_elf.c:369: warning: comparison is always false due to limited range of data type
> > fs/binfmt_elf.c: In function `load_elf_binary':
> > fs/binfmt_elf.c:780: warning: comparison is always false due to limited range of data type
> >
> > It's the comparision "elf_ppnt->p_memsz > TASK_SIZE".
> >
> > p_memsz is Elf32_Word, TASK_SIZE is defined as
> > #define TASK_SIZE ((unsigned long)-VPTE_SIZE)
> >
> > At the first glance I can't see what's wrong here.
>
> The compiler is telling us that the condition is always false because a 32-bit
> value can never have the codition being tested against a 64-bit one (TASK_SIZE).
> I've tried everything to kill this warning, even casting both sides of the
> conparison to 64-bit, but gcc can still see things clearly.
>
> So just comment out the -Werror line in arch/sparc64/kernel/Makefile which is
> how I'm (unfortunately) solving this for now.
what about the good old
eppnt->p_memsz - TASK_SIZE > 0
HTH,
Herbert
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2004-04-17 3:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-14 8:33 Meelis Roos
2004-04-14 18:53 ` David S. Miller
2004-04-17 3:29 ` Herbert Poetzl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040417032912.GA23888@MAIL.13thfloor.at \
--to=herbert@13thfloor.at \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®