From: Chris Wright <chrisw@osdl.org>
To: Andrea Arcangeli <andrea@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
arjanv@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: updated-fbmem-patch.patch
Date: Wed, 21 Apr 2004 15:41:53 -0700 [thread overview]
Message-ID: <20040421154153.O22989@build.pdx.osdl.net> (raw)
In-Reply-To: <20040421021008.GM29954@dualathlon.random>; from andrea@suse.de on Wed, Apr 21, 2004 at 04:10:08AM +0200
* Andrea Arcangeli (andrea@suse.de) wrote:
> http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.5/2.6.5-mm4/broken-out/updated-fbmem-patch.patch
>
> this uses get_user for the set_cmap operation too.
>
> --- 2.6.5-aa3/drivers/video/fbmem.c.~1~ 2004-04-04 08:09:23.000000000 +0200
> +++ 2.6.5-aa3/drivers/video/fbmem.c 2004-04-21 03:11:05.878951424 +0200
> @@ -1034,11 +1034,11 @@ fb_ioctl(struct inode *inode, struct fil
> case FBIOPUTCMAP:
> if (copy_from_user(&cmap, (void *) arg, sizeof(cmap)))
> return -EFAULT;
> - return (fb_set_cmap(&cmap, 0, info));
> + return (fb_set_cmap(&cmap, 1, info));
0 is userspace, 1 is kernel space. this change looks wrong.
Perhaps the change below so comment is in sync with code.
--- a/drivers/video/fbcmap.c Fri Feb 6 00:30:15 2004
+++ b/drivers/video/fbcmap.c Wed Apr 21 15:40:56 2004
@@ -207,7 +207,7 @@
/**
* fb_set_cmap - set the colormap
* @cmap: frame buffer colormap structure
- * @kspc: boolean, 0 copy local, 1 get_user() function
+ * @kspc: boolean, 0 get_user() function , 1 copy local
* @info: frame buffer info structure
*
* Sets the colormap @cmap for a screen of device @info.
next prev parent reply other threads:[~2004-04-21 22:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-21 2:10 updated-fbmem-patch.patch Andrea Arcangeli
2004-04-21 22:41 ` Chris Wright [this message]
2004-04-21 22:57 ` updated-fbmem-patch.patch Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040421154153.O22989@build.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=akpm@osdl.org \
--cc=andrea@suse.de \
--cc=arjanv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®