From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S264584AbUDVRSS@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S264584AbUDVRSS (ORCPT <rfc822;willy@w.ods.org>);
	Thu, 22 Apr 2004 13:18:18 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264590AbUDVRSR
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 22 Apr 2004 13:18:17 -0400
Received: from fw.osdl.org ([65.172.181.6]:49536 "EHLO mail.osdl.org")
	by vger.kernel.org with ESMTP id S264584AbUDVRSH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 22 Apr 2004 13:18:07 -0400
Date: Thu, 22 Apr 2004 10:12:06 -0700
From: "Randy.Dunlap" <rddunlap@osdl.org>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: kieran@ihateaol.co.uk, linux-kernel@vger.kernel.org,
       linux-scsi@vger.kernel.org
Subject: Re: Why is CONFIG_SCSI_QLA2X_X always enabled?
Message-Id: <20040422101206.70133b42.rddunlap@osdl.org>
In-Reply-To: <1082651974.1778.52.camel@mulgrave>
References: <4087E95F.5050409@ihateaol.co.uk>
	<20040422092853.55d0b011.rddunlap@osdl.org>
	<1082651974.1778.52.camel@mulgrave>
Organization: OSDL
X-Mailer: Sylpheed version 0.9.10 (GTK+ 1.2.10; i686-pc-linux-gnu)
X-Face: +5V?h'hZQPB9<D&+Y;ig/:L-F$8p'$7h4BBmK}zo}[{h,eqHI1X}]1UhhR{49GL33z6Oo!`
 !Ys@HV,^(Xp,BToM.;N_W%gT|&/I#H@Z:ISaK9NqH%&|AO|9i/nB@vD:Km&=R2_?O<_V^7?St>kW
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On 22 Apr 2004 12:39:34 -0400 James Bottomley wrote:

| On Thu, 2004-04-22 at 12:28, Randy.Dunlap wrote:
| > A nuisance or annoyance perhaps.  Here's a patch for it.
| 
| No, it's a variable used to determine whether the user should be asked
| about qla2xxx or not.

As it is, for some large %age of users (say 99% ?), those 6 qla drivers
show up in the config menu when they aren't needed or wanted.
They get in the way.

| The proposed patch is obviously not correct, because we don't want the
| user to be asked about it.

You want it to always be presented (if PCI && SCSI) ?
No, it should be a selectable option iff PCI && SCSI.

| A better fix might be to make the qla2xxx a menu dependent on SCSI &&
| PCI

It already does.  The problem is that is defaults to the value of
(SCSI && PCI) when a large number of people don't need that
default value.  IOW, it's a bad choice for a default value.

--
~Randy
"We have met the enemy and he is us."  -- Pogo (by Walt Kelly)