From: Andi Kleen <ak@muc.de>
To: "David S. Miller" <davem@redhat.com>
Cc: Andi Kleen <ak@muc.de>,
jmorris@redhat.com, linux-kernel@vger.kernel.org,
vda@port.imtp.ilyichevsk.odessa.ua
Subject: Re: Large inlines in include/linux/skbuff.h
Date: 23 Apr 2004 00:34:01 +0200 [thread overview]
Date: Fri, 23 Apr 2004 00:34:01 +0200 [thread overview]
Message-ID: <20040422223401.GB81305@colin2.muc.de> (raw)
In-Reply-To: <20040422152525.28ee1d5f.davem@redhat.com>
On Thu, Apr 22, 2004 at 03:25:25PM -0700, David S. Miller wrote:
> On 23 Apr 2004 00:23:26 +0200
> Andi Kleen <ak@muc.de> wrote:
>
> > > Of course, but it would be good to see some measurements.
> >
> > It's useless in this case. networking is dominated by cache misses
> > and locks and a modern CPU can do hundreds of function calls in a
> > single cache miss.
>
> Indeed, this change does influence the I-cache footprint of the
> networking, so I conclude that it is relevant in this case.
All it does it is to lower the cache foot print, not enlarge it.
So even if it made a difference it could only get better.
It's extremly unlikely to make it detectable worse.
-Andi
next prev parent reply other threads:[~2004-04-22 22:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1NvJL-1QO-9@gated-at.bofh.it>
[not found] ` <1NAJr-61F-3@gated-at.bofh.it>
2004-04-22 14:59 ` Andi Kleen
2004-04-22 15:15 ` James Morris
2004-04-22 15:37 ` Eric Dumazet
[not found] ` <200404221927.34717.vda@port.imtp.ilyichevsk.odessa.ua>
2004-04-22 19:24 ` Eric Dumazet
2004-04-22 22:23 ` Andi Kleen
2004-04-22 22:25 ` David S. Miller
2004-04-22 22:34 ` Andi Kleen [this message]
2004-04-22 22:35 ` David S. Miller
[not found] ` <1NRqX-2GI-15@gated-at.bofh.it>
[not found] ` <1NRqX-2GI-13@gated-at.bofh.it>
2004-04-22 19:51 ` Andi Kleen
2004-04-21 19:26 Denis Vlasenko
2004-04-22 0:47 ` James Morris
[not found] ` <200404221756.46240.vda@port.imtp.ilyichevsk.odessa.ua>
2004-04-22 18:36 ` David S. Miller
[not found] ` <200404222239.34760.vda@port.imtp.ilyichevsk.odessa.ua>
2004-04-22 22:10 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040422223401.GB81305@colin2.muc.de \
--to=ak@muc.de \
--cc=davem@redhat.com \
--cc=jmorris@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vda@port.imtp.ilyichevsk.odessa.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®