mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: davem@redhat.com, anton@samba.org, Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: sparc64 2.6.6-rc2-mm2 build busted: usb/core/hub.c hubstatus
Date: Mon, 26 Apr 2004 20:49:47 -0700	[thread overview]
Message-ID: <20040426204947.797bd7c2.pj@sgi.com> (raw)

Trying to build sparc64 as of 2.6.6-rc2-mm2, using the cross_compile
tools from http://developer.osdl.org/dev/plm/cross_compile/ (nice
tools - thanks!) fails for two reasons:

1) Broken drivers/char/drm/ffb_drv.c:

      CC [M]  drivers/char/drm/ffb_drv.o
    In file included from drivers/char/drm/ffb_drv.c:336:
    drivers/char/drm/drm_drv.h:547: error: `ffb_PCI_IDS' undeclared here (not in a function)
    drivers/char/drm/drm_drv.h:547: error: initializer element is not constant
    drivers/char/drm/drm_drv.h:547: error: (near initialization for `ffb_pciidlist[0]')
    drivers/char/drm/ffb_drv.c:225: warning: `ffb_count_card_instances' defined but not used
    make[3]: *** [drivers/char/drm/ffb_drv.o] Error 1

   Andrew already reported this last week - something about missing PCI ID's.

2) An undefined 'hubstatus' variable in drivers/usb/core/hub.c:

      CC      drivers/usb/core/hub.o
    drivers/usb/core/hub.c: In function `hub_port_connect_change':
    drivers/usb/core/hub.c:1343: error: `hubstatus' undeclared (first use in this function)
    drivers/usb/core/hub.c:1343: error: (Each undeclared identifier is reported only once
    drivers/usb/core/hub.c:1343: error: for each function it appears in.)
    make[3]: *** [drivers/usb/core/hub.o] Error 1

  As a total shot in the dark, the following fixes the build (I've no clue
  if it is the right fix):

===== drivers/usb/core/hub.c 1.93 vs edited =====
*** /tmp/hub.c-1.93-21850	Mon Apr 26 00:44:33 2004
--- drivers/usb/core/hub.c	Mon Apr 26 20:44:58 2004
*************** static void hub_port_connect_change(stru
*** 1340,1346 ****
  				dev_dbg(&dev->dev, "get status %d ?\n", status);
  				continue;
  			}
! 			cpu_to_le16s(&hubstatus);
  			if ((devstat & (1 << USB_DEVICE_SELF_POWERED)) == 0) {
  				dev_err(&dev->dev,
  					"can't connect bus-powered hub "
--- 1340,1346 ----
  				dev_dbg(&dev->dev, "get status %d ?\n", status);
  				continue;
  			}
! 			cpu_to_le16s(&devstat);
  			if ((devstat & (1 << USB_DEVICE_SELF_POWERED)) == 0) {
  				dev_err(&dev->dev,
  					"can't connect bus-powered hub "


-- 
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <pj@sgi.com> 1.650.933.1373

             reply	other threads:[~2004-04-27  3:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-27  3:49 Paul Jackson [this message]
2004-04-27  4:52 ` Ian Kent
2004-04-27 14:48   ` raven
2004-04-28  0:14     ` Dave Airlie
2004-04-28  2:29       ` Ian Kent
2004-04-28  2:27         ` Dave Airlie
2004-04-28 13:34           ` raven
2004-05-01 10:31             ` raven
2004-04-28  3:25       ` Randy.Dunlap
2004-04-28 20:22         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040426204947.797bd7c2.pj@sgi.com \
    --to=pj@sgi.com \
    --cc=akpm@osdl.org \
    --cc=anton@samba.org \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®