From: Andrew Morton <akpm@osdl.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: apw@shadowen.org, agl@us.ibm.com, mbligh@us.ibm.com,
linux-kernel@vger.kernel.org, linuxppc64-dev@lists.linuxppc.org
Subject: Re: put_page() tries to handle hugepages but fails
Date: Mon, 26 Apr 2004 21:47:57 -0700 [thread overview]
Message-ID: <20040426214757.2c7d8ed5.akpm@osdl.org> (raw)
In-Reply-To: <20040427043652.GF514@zax>
David Gibson <david@gibson.dropbear.id.au> wrote:
>
> + if (put_page_testzero(page))
> + free_huge_page(page);
Well yes, but this is assuming that compound pages are always hugetlb pages.
It's true at present, but it doesn't have to always be true. The cost of
the destructor is zilch, so why not?
Please review the changes which went into 2.6.6-rc2-mm2.
next prev parent reply other threads:[~2004-04-27 4:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-23 8:18 David Gibson
2004-04-23 8:34 ` Andrew Morton
2004-04-23 10:28 ` William Lee Irwin III
2004-04-23 10:35 ` Andrew Morton
2004-04-23 10:47 ` William Lee Irwin III
2004-04-23 11:28 ` William Lee Irwin III
2004-04-27 4:36 ` David Gibson
2004-04-27 4:41 ` David Gibson
2004-04-27 4:47 ` Andrew Morton [this message]
2004-04-27 5:05 ` David Gibson
2004-04-27 5:15 ` Andrew Morton
2004-04-27 5:16 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040426214757.2c7d8ed5.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=agl@us.ibm.com \
--cc=apw@shadowen.org \
--cc=david@gibson.dropbear.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@lists.linuxppc.org \
--cc=mbligh@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®