mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nathan Scott <nathans@sgi.com>
To: Andreas Gruenbacher <agruen@suse.de>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Return more useful error number when acls are too large
Date: Tue, 27 Apr 2004 11:24:40 +1000	[thread overview]
Message-ID: <20040427112440.B604510@wobbly.melbourne.sgi.com> (raw)
In-Reply-To: <1082973939.3295.16.camel@winden.suse.de>; from agruen@suse.de on Mon, Apr 26, 2004 at 12:27:58PM +0200

hi Andreas,

On Mon, Apr 26, 2004 at 12:27:58PM +0200, Andreas Gruenbacher wrote:
> Hello,
> 
> could you please add this to mainline? Getting EINVAL when an acl
> becomes too large is quite confusing.
> 
>   	if (acl) {
>  		if (acl->a_count > EXT2_ACL_MAX_ENTRIES)
> -			return -EINVAL;
> +			return -ENOSPC;

That seems an odd error code to change it to, since its not
related to the device running out of free space right?  Maybe
use -E2BIG instead?

XFS has a similar check (different limit as you know), so is
also affected by this; could you update XFS at the same time
with whatever value gets chosen, if its not EINVAL?  Or just
let me know what gets chosen & I'll fix it up later.

thanks.

-- 
Nathan

  reply	other threads:[~2004-04-27  1:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-26 10:27 Andreas Gruenbacher
2004-04-27  1:24 ` Nathan Scott [this message]
2004-04-27 18:07   ` Andreas Gruenbacher
2004-04-27 18:32 ` J. Bruce Fields
2004-04-27 19:10   ` Andreas Gruenbacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040427112440.B604510@wobbly.melbourne.sgi.com \
    --to=nathans@sgi.com \
    --cc=agruen@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®