From: Christoph Hellwig <hch@infradead.org>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Andrew Morton <akpm@osdl.org>,
sgoel01@yahoo.com, linux-kernel@vger.kernel.org
Subject: Re: 2.6.6-rc{1,2} bad VM/NFS interaction in case of dirty page writeback
Date: Wed, 28 Apr 2004 17:38:11 +0100 [thread overview]
Message-ID: <20040428173811.A1505@infradead.org> (raw)
In-Reply-To: <1083169062.2856.36.camel@lade.trondhjem.org>; from trond.myklebust@fys.uio.no on Wed, Apr 28, 2004 at 12:17:42PM -0400
On Wed, Apr 28, 2004 at 12:17:42PM -0400, Trond Myklebust wrote:
> On Wed, 2004-04-28 at 01:29, Christoph Hellwig wrote:
> > There's nothing speaking against probing for more dirty pages before and
> > after the one ->writepage wants to write out and send the big request
> > out. XFS does this to avoid creating small extents when converting from
> > delayed allocated space to real extents.
>
> You are referring to xfs_probe_unmapped_page()?
Yes, and the two other functions doing similar stuff.
> True: we could do
> that... In fact we could do it a lot more efficiently now that we have
> the pagevec_lookup_tag() interface.
Yes pagevec are much more efficient for that. In fact I have a workarea
switching over XFS to use pagevec for that probing.
I'm not yet sure where I'm heading with revamping xfs_aops.c, but what
I'd love to see in the end is more or less xfs implementing only
writepages and some generic implement writepage as writepages wrapper.
next prev parent reply other threads:[~2004-04-28 19:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-27 1:12 Shantanu Goel
2004-04-27 2:15 ` Andrew Morton
2004-04-27 3:11 ` Trond Myklebust
2004-04-27 3:59 ` Andrew Morton
2004-04-27 5:23 ` Trond Myklebust
2004-04-27 5:58 ` Andrew Morton
2004-04-27 11:44 ` Shantanu Goel
2004-04-27 15:36 ` Trond Myklebust
2004-04-28 0:47 ` Shantanu Goel
2004-04-28 1:02 ` Andrew Morton
2004-04-28 1:28 ` Trond Myklebust
2004-04-28 1:38 ` Andrew Morton
2004-04-28 5:29 ` Christoph Hellwig
2004-04-28 16:17 ` Trond Myklebust
2004-04-28 16:38 ` Christoph Hellwig [this message]
2004-04-28 19:07 ` Andrew Morton
2004-04-29 1:48 ` Nathan Scott
2004-04-29 8:27 ` Christoph Hellwig
2004-04-27 6:10 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040428173811.A1505@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sgoel01@yahoo.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®