From: Andrew Morton <akpm@osdl.org>
To: "Jose R. Santos" <jrsantos@austin.ibm.com>
Cc: jrsantos@austin.ibm.com, linux-kernel@vger.kernel.org,
anton@samba.org, dheger@us.ibm.com
Subject: Re: [PATCH] dentry and inode cache hash algorithm performance changes.
Date: Fri, 30 Apr 2004 15:02:56 -0700 [thread overview]
Message-ID: <20040430150256.25735762.akpm@osdl.org> (raw)
In-Reply-To: <20040430213324.GK14271@rx8.ibm.com>
"Jose R. Santos" <jrsantos@austin.ibm.com> wrote:
>
> On 04/30/04 15:57:01, Jose R. Santos wrote:
> > err... Wrote the patch to fast. It should read
> >
> > tmp = (hashval * sb) ^ (GOLDEN_RATIO_PRIME + hashval) / L1_CACHE_BYTES
> >
> > I screw up... I'll send a fixed patch in a while.
>
> Just notice I've made another error in the inode hash code.
>
> Fixed patch (I hope) with beautification.
Does this mean you need to redo the instrumentation and benchmarking? If
so, please do that and send the numbers along? There's no particular
urgency on that, but we should do it.
Also, I'd be interested in understanding what the input to the hashing
functions looked like in this testing. It could be that the new hash just
happens to work well with one particular test's dataset. Please convince
us otherwise ;)
next prev parent reply other threads:[~2004-04-30 22:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040430191539.GC14271@rx8.ibm.com>
[not found] ` <20040430131832.45be6956.akpm@osdl.org>
2004-04-30 20:57 ` Jose R. Santos
2004-04-30 21:33 ` Jose R. Santos
2004-04-30 22:02 ` Andrew Morton [this message]
2004-04-30 23:42 ` Jose R. Santos
2004-05-04 13:12 ` Jose R. Santos
2004-05-04 18:55 ` Andrew Morton
2004-05-07 13:04 ` Jose R. Santos
2004-05-08 1:03 ` Dave Hansen
2004-04-30 19:55 Jose R. Santos
2004-05-01 12:08 ` Olaf Dietsche
2004-05-01 15:08 ` Jose R. Santos
2004-05-20 13:34 ` Raghavan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040430150256.25735762.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=anton@samba.org \
--cc=dheger@us.ibm.com \
--cc=jrsantos@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®