On Fri, Apr 30, 2004 at 10:48:04PM -0700, Greg KH wrote:
> On Thu, Apr 29, 2004 at 02:02:50PM +0200, stefan.eletzhofer@eletztrick.de wrote:
> > +	if ( !buf || !client ) {
> 
> Can you clean up your exuberant use of spaces in 'if' statements, and
> function calls?  It's not the proper kernel style.
> 
> > +DONE:
> 
> Lowercase please
> 
> > +	if ( ret ) {
> > +		if ( d ) kfree( d );
> 
> No need to check a pointer before sending it to kfree.

Ok, that should be it. I've also ran the source through Lindent,
which fixed some further things. I've reverted the indention change
for labels, though. I think labels should be at level zero, should
they?

thanks,
 Stefan E.

> 
> thanks,
> 
> greg k-h
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Eletztrick Computing - Customized Linux Development
Stefan Eletzhofer, Marktstrasse 43, DE-88214 Ravensburg
http://www.eletztrick.de