From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264277AbUEDJff (ORCPT ); Tue, 4 May 2004 05:35:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264286AbUEDJff (ORCPT ); Tue, 4 May 2004 05:35:35 -0400 Received: from mail.fh-wedel.de ([213.39.232.194]:21447 "EHLO mail.fh-wedel.de") by vger.kernel.org with ESMTP id S264277AbUEDJfe (ORCPT ); Tue, 4 May 2004 05:35:34 -0400 Date: Tue, 4 May 2004 11:23:43 +0200 From: =?iso-8859-1?Q?J=F6rn?= Engel To: viro@parcelfarce.linux.theplanet.co.uk Cc: Andrew Morton , Linus Torvalds , davidm@hpl.hp.com, bunk@fs.tum.de, eyal@eyal.emu.id.au, linux-dvb-maintainer@linuxtv.org, linux-kernel@vger.kernel.org Subject: Re: 2.6.6-rc3: modular DVB tda1004x broken Message-ID: <20040504092343.GA9053@wohnheim.fh-wedel.de> References: <20040501175134.243b389c.akpm@osdl.org> <16534.35355.671554.321611@napali.hpl.hp.com> <20040503140251.274e1239.akpm@osdl.org> <20040503211607.GG17014@parcelfarce.linux.theplanet.co.uk> <20040503212450.GC31580@wohnheim.fh-wedel.de> <20040503215434.GI17014@parcelfarce.linux.theplanet.co.uk> <20040503223317.GD31580@wohnheim.fh-wedel.de> <20040504001450.GK17014@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20040504001450.GK17014@parcelfarce.linux.theplanet.co.uk> User-Agent: Mutt/1.3.28i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 4 May 2004 01:14:50 +0100, viro@parcelfarce.linux.theplanet.co.uk wrote: > On Tue, May 04, 2004 at 12:33:17AM +0200, Jörn Engel wrote: > > That cannot be all. What about these two? Not sure if my patch is > > correct or it should rather s/O_RDONLY/FMODE_READ/. > > WTF does that have to sys_open(9) or open(9)? > > And no, dentry_open() does not take FMODE_... - open_namei() does, > but dentry_open() takes flags unchanged. Just take a look at > fs/open.c::filp_open() - flags are passed unchanged. True, stupid me. Jörn -- It does not matter how slowly you go, so long as you do not stop. -- Confucius