From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Chris Wright <chrisw@osdl.org>
Cc: manfred@colorfullife.com, akpm@osdl.org, torvalds@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] simplify mqueue_inode_info->messages allocation
Date: Wed, 5 May 2004 10:55:23 -0300 [thread overview]
Message-ID: <20040505135523.GC1418@logos.cnet> (raw)
In-Reply-To: <20040504183722.H21045@build.pdx.osdl.net>
On Tue, May 04, 2004 at 06:37:22PM -0700, Chris Wright wrote:
> * Chris Wright (chrisw@osdl.org) wrote:
> > --- ./ipc/mqueue.c~single_alloc 2004-05-04 15:16:34.000000000 -0700
> > +++ ./ipc/mqueue.c~ 2004-05-04 15:59:25.000000000 -0700
>
> Ugh! Andrew pointed out to me that this is crap. Sorry about the added
> noise. Here's a patch relative to a file that actually exists.
While we're at it, in do_create:
ret = vfs_create(dir->d_inode, dentry, mode, NULL);
if (ret) {
kfree(msgs);
return ERR_PTR(ret);
The msgs pointer can be NULL. Isnt that going to BUG if so?
next prev parent reply other threads:[~2004-05-05 22:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-05 0:42 [PATCH] fix memleak in sys_mq_timedsend Chris Wright
2004-05-05 0:47 ` [PATCH] fix queues_count accounting in mqueue_delete_inode() Chris Wright
2004-05-05 1:06 ` [PATCH] simplify mqueue_inode_info->messages allocation Chris Wright
2004-05-05 1:37 ` Chris Wright
2004-05-05 13:55 ` Marcelo Tosatti [this message]
2004-05-05 22:30 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040505135523.GC1418@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=akpm@osdl.org \
--cc=chrisw@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®