From: Andrew Morton <akpm@osdl.org>
To: FabF <Fabian.Frederick@skynet.be>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6.6-rc3-mm2] genhd-unregister warn handling
Date: Thu, 6 May 2004 14:40:45 -0700 [thread overview]
Message-ID: <20040506144045.0711b4db.akpm@osdl.org> (raw)
In-Reply-To: <1083866562.5865.6.camel@bluerhyme.real3>
FabF <Fabian.Frederick@skynet.be> wrote:
>
> Here's a patch against 2.6.6-rc3-mm2 genhd.c unregister_blkdev
>
> -Standardize function for void xxx
> -Split uncorresponding return
> -Add printks
> -Merge kfree to positive case
>
> Could you apply ?
It seems to be a gratuitous change to the modules API.
A quick grep shows that a lot of drivers are currently testing the
unregister_blkdev() return value - your patch breaks them all.
I don't see much point in making changes in this area.
prev parent reply other threads:[~2004-05-06 21:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-06 18:02 FabF
2004-05-06 21:40 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040506144045.0711b4db.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=Fabian.Frederick@skynet.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®