From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: "'Jens Axboe'" <axboe@suse.de>, "Andrew Morton" <akpm@osdl.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: RE: Cache queue_congestion_on/off_threshold
Date: Thu, 6 May 2004 13:30:57 -0700 [thread overview]
Message-ID: <200405062030.i46KUuF13625@unix-os.sc.intel.com> (raw)
In-Reply-To: <20040506064301.GC10069@suse.de>
>>>> Jens Axboe wrote on Wed, May 05, 2004 11:43 PM
> On Wed, May 05 2004, Andrew Morton wrote:
> > Jens Axboe <axboe@suse.de> wrote:
> > >
> > > Do you have any numbers at all for this? I'd say these calculations are
> > > severly into the noise area when submitting io.
> >
> > The difference will not be measurable, but I think the patch makes sense
> > regardless of what the numbers say.
>
> Humm dunno, I'd rather save the sizeof(int) * 2.
Strictly speaking from memory consumption point of view, it probably comes
for free since sizeof(struct request_queue) currently is 456 bytes on x86
and 816 on 64bit arch. The structure is being rounded to 512 or 1024 with
kmalloc. If it is on the borderline to next kmalloc size, it probably should
be revisited. But so far it has been noise on the positive side.
- Ken
next prev parent reply other threads:[~2004-05-06 20:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-05 22:12 Chen, Kenneth W
2004-05-06 6:20 ` Jens Axboe
2004-05-06 6:34 ` Andrew Morton
2004-05-06 6:43 ` Jens Axboe
2004-05-06 20:30 ` Chen, Kenneth W [this message]
2004-05-07 3:02 ` Andrew Morton
2004-05-07 9:35 ` Jens Axboe
2004-05-06 20:29 ` Chen, Kenneth W
2004-05-07 9:39 ` Jens Axboe
2004-05-07 22:00 ` Chen, Kenneth W
2004-05-10 14:30 ` Jens Axboe
2004-05-10 14:43 ` Nick Piggin
2004-05-10 14:44 ` Jens Axboe
2004-05-11 3:22 ` Nick Piggin
2004-05-12 5:32 ` Chen, Kenneth W
2004-05-12 7:05 ` Jens Axboe
2004-05-12 13:48 ` Jens Axboe
2004-05-12 14:22 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200405062030.i46KUuF13625@unix-os.sc.intel.com \
--to=kenneth.w.chen@intel.com \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®