From: "David S. Miller" <davem@redhat.com>
To: Clay Haapala <chaapala@cisco.com>
Cc: mroos@linux.ee, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto/crc32c.c (was Re: CRC32c warning on sparc64)
Date: Fri, 7 May 2004 15:01:08 -0700 [thread overview]
Message-ID: <20040507150108.7f909b3c.davem@redhat.com> (raw)
In-Reply-To: <yqujr7tx1gzz.fsf@chaapala-lnx2.cisco.com>
On Thu, 06 May 2004 14:40:32 -0500
Clay Haapala <chaapala@cisco.com> wrote:
> Well, it's my opinion that using "size_t" is correct usage of type in
> this case. So here's my thinking:
>
> * we leave lib/crc32c() as it is with size_t, as it is meant to be
> derived from crc32() and that uses size_t.
>
> * crypto/crc32c is a wrapper for lib/crc32c. The interface it
> presents to the rest of the crypto routines should agree. My bad.
> So, let us let it translate with a cast, as in the patch below.
This works for me, patch applied.
prev parent reply other threads:[~2004-05-07 22:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-06 17:38 CRC32c warning on sparc64 Meelis Roos
2004-05-06 19:40 ` [PATCH] crypto/crc32c.c (was Re: CRC32c warning on sparc64) Clay Haapala
2004-05-07 22:01 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040507150108.7f909b3c.davem@redhat.com \
--to=davem@redhat.com \
--cc=chaapala@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome