On Fri, May 07, 2004 at 10:47:56AM -0500, Steve Lord wrote: > >- if (mlen > sizeof(buf)) > >+ obj.data = kmalloc(1024, GFP_KERNEL); > >+ if (!obj.data) > >+ return -ENOMEM; > >+ > >+ if (mlen > 1024) { > > That's what I hate about all of this, just think how much stack that > kmalloc can take in low memory situations.... it might end up in > writepage on another nfs file.... it clearly needs to be GFP_NOFS