From: Christoph Hellwig <hch@infradead.org>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@osdl.org>, Andrea Arcangeli <andrea@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rmap 24 pte_young first
Date: Sat, 8 May 2004 23:22:39 +0100 [thread overview]
Message-ID: <20040508232239.B12293@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.44.0405082255430.26569-100000@localhost.localdomain>; from hugh@veritas.com on Sat, May 08, 2004 at 10:56:26PM +0100
On Sat, May 08, 2004 at 10:56:26PM +0100, Hugh Dickins wrote:
> From: Andrea Arcangeli <andrea@suse.de>
>
> rmap test pte_young before doing the costlier ptep_test_and_clear_young.
>
> rmap.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> --- rmap24/mm/rmap.c 2004-05-08 20:54:32.421571016 +0100
> +++ rmap25/mm/rmap.c 2004-05-08 20:54:43.358908288 +0100
> @@ -198,7 +198,7 @@ static int page_referenced_one(struct pa
> if (page_to_pfn(page) != pte_pfn(*pte))
> goto out_unmap;
>
> - if (ptep_test_and_clear_young(pte))
> + if (pte_young(*pte) && ptep_test_and_clear_young(pte))
stupid question - shouldn't the pte_young check simply move to
the beginning of ptep_test_and_clear_young?
next prev parent reply other threads:[~2004-05-08 22:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-08 21:55 [PATCH] rmap 24 no rmap fastcalls Hugh Dickins
2004-05-08 21:56 ` [PATCH] rmap 24 pte_young first Hugh Dickins
2004-05-08 22:22 ` Christoph Hellwig [this message]
2004-05-08 22:39 ` Hugh Dickins
2004-05-08 22:45 ` Russell King
2004-05-08 22:59 ` Hugh Dickins
2004-05-09 10:31 ` Hugh Dickins
2004-05-08 21:58 ` [PATCH] rmap 26 __setup_arg_pages Hugh Dickins
2004-05-08 22:00 ` [PATCH] rmap 27 memset 0 vma Hugh Dickins
2004-05-08 22:01 ` [PATCH] rmap 28 remove_vm_struct Hugh Dickins
2004-05-08 22:02 ` [PATCH] rmap 29 VM_RESERVED safety Hugh Dickins
2004-05-08 22:04 ` [PATCH] rmap 30 fix bad mapcount Hugh Dickins
2004-05-08 22:05 ` [PATCH] rmap 31 unlikely bad memory Hugh Dickins
2004-05-08 22:06 ` [PATCH] rmap 32 zap_pmd_range wrap Hugh Dickins
2004-05-08 22:21 ` [PATCH] rmap 24 no rmap fastcalls Christoph Hellwig
2004-05-08 22:32 ` Hugh Dickins
2004-05-08 22:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040508232239.B12293@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=andrea@suse.de \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®