mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sebastian Schmidt <yath@yath.eu.org>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] hci-usb bugfix
Date: Sun, 9 May 2004 21:47:15 +0200	[thread overview]
Message-ID: <20040509194715.GA2163@eniac.lan.yath.eu.org> (raw)

Hi,

this is a little patch against 2.6.6-rc3 which fixes the Oops when
unplugging an USB Bluetooth device.

hci_usb_disconnect() got called recursively which caused
sysfs_hash_and_remove() finally to dereference a NULL pointer.

--- SNIP ---
diff -uNr linux-2.6.6-rc3.old/drivers/bluetooth/hci_usb.c linux-2.6.6-rc3/drivers/bluetooth/hci_usb.c
--- linux-2.6.6-rc3.old/drivers/bluetooth/hci_usb.c     2004-05-09 20:25:00.000000000 +0200
+++ linux-2.6.6-rc3/drivers/bluetooth/hci_usb.c 2004-05-09 20:28:30.000000000 +0200
@@ -986,8 +986,21 @@

        hci_usb_close(hdev);

-       if (husb->isoc_iface)
+       if (husb->isoc_iface) {
+#if 0
                usb_driver_release_interface(&hci_usb_driver, husb->isoc_iface);
+#else
+               /* do the same as usb_driver_release_interface would do,
+                * except calling diconnect().
+                * usb_driver_release_interface() _does_ check if
+                *  are in disconnect() or add, but I really dunno 
+                *  where dev->driver_list or dev->bus_list gets set.
+                *      -- yath
+                */
+               husb->isoc_iface->dev.driver = NULL;
+               usb_set_intfdata(husb->isoc_iface, NULL);
+#endif
+       }

        if (hci_unregister_dev(hdev) < 0)
                BT_ERR("Can't unregister HCI device %s", hdev->name);
--- SNAP ---

Please apply it,

Sebastian


             reply	other threads:[~2004-05-09 19:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-09 19:47 Sebastian Schmidt [this message]
2004-05-09 20:39 ` Marcel Holtmann
2004-05-10 16:13   ` Alan Stern
2004-05-10 16:19     ` Marcel Holtmann
2004-05-10 16:36       ` Oliver Neukum
2004-05-10 16:52         ` Marcel Holtmann
2004-05-10 19:15           ` Oliver Neukum
2004-05-10 19:39             ` Marcel Holtmann
2004-05-10 20:38               ` Oliver Neukum
2004-05-10 20:58                 ` Marcel Holtmann
2004-05-10 17:19       ` Alan Stern
2004-05-10 17:27         ` Marcel Holtmann
2004-05-10 17:52           ` Alan Stern
2004-05-10 18:07             ` Marcel Holtmann
2004-05-11 14:59               ` Alan Stern
2004-05-12 13:13                 ` Marcel Holtmann
2004-05-09 22:37 ` Soeren Sonnenburg
2004-05-10 10:40   ` Marcel Holtmann
2004-05-11  7:30     ` Soeren Sonnenburg
2004-05-12 13:15       ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040509194715.GA2163@eniac.lan.yath.eu.org \
    --to=yath@yath.eu.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®