Christoph Hellwig wrote: > On Tue, May 04, 2004 at 01:04:51AM -0500, Bob Tracy wrote: > > Support for additional sysfs class device attributes has been added: > > two are read-only (irq, ioport), > > sorry to bother you again, but I don't think these belong into a scsi > LLDD. it's attributes for the underlying bus. For pci you get these > information already, but the pcmcia infrastructure isn't quite ready > yet. I saw the need :-), but agree that those attributes aren't a good fit where they were placed. That code has been removed. > > one is read-write (fast_pio). The > > read-write attribute is a per-instance flag indicating the PIO speed > > of the particular HBA: valid values are 1 (enabled -- default) and 0 > > (disabled). > > this one is nice. Thanks. "Round 6" attached: the patch set applies cleanly to 2.6.5, and possibly 2.6.6 (haven't tried it). If there's nothing else to be done, let's push this upstream for 2.6.7. -- ----------------------------------------------------------------------- Bob Tracy WTO + WIPO = DMCA? http://www.anti-dmca.org rct@frus.com -----------------------------------------------------------------------