From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S263448AbUEKT3b@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S263448AbUEKT3b (ORCPT <rfc822;willy@w.ods.org>);
	Tue, 11 May 2004 15:29:31 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263460AbUEKT3b
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 11 May 2004 15:29:31 -0400
Received: from fw.osdl.org ([65.172.181.6]:13782 "EHLO mail.osdl.org")
	by vger.kernel.org with ESMTP id S263448AbUEKT33 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 11 May 2004 15:29:29 -0400
Date: Tue, 11 May 2004 12:28:59 -0700
From: Andrew Morton <akpm@osdl.org>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: geoff@linux.jf.intel.com, linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: [RFC] [PATCH] Performance of del_timer_sync
Message-Id: <20040511122859.33c763ef.akpm@osdl.org>
In-Reply-To: <200405111923.i4BJN6F17770@unix-os.sc.intel.com>
References: <20040511121126.73f5fdeb.akpm@osdl.org>
	<200405111923.i4BJN6F17770@unix-os.sc.intel.com>
X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; i386-redhat-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

"Chen, Kenneth W" <kenneth.w.chen@intel.com> wrote:
>
> >  del_again:
>  >  	ret += del_timer(timer);
>  > +	if (!ret)
>  > +		return 0;
>  >
>  >  	for_each_cpu(i) {
>  >  		base = &per_cpu(tvec_bases, i);
> 
> 
>  Hehe ... , first thing we tried :-). But has problem that if timeout
>  function is running while del_timer_sync() is called, it returns
>  without waiting.

eh?  If del_timer() returns non-zero, that means that the timer was
successfully deleted before it triggered.