From: Andrew Morton <akpm@osdl.org>
To: dsaxena@plexity.net
Cc: wim@iguana.be, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6] Watchdog timer for Intel IXP4xx CPUs
Date: Tue, 11 May 2004 14:33:52 -0700 [thread overview]
Message-ID: <20040511143352.096bc071.akpm@osdl.org> (raw)
In-Reply-To: <20040511212235.GA7729@plexity.net>
Deepak Saxena <dsaxena@plexity.net> wrote:
>
>
> Following patch against 2.6.6 adds a driver for the watchdogs on the
> Intel IXP4xx family of network processors (ARM). Please apply.
>
> ...
> +
> + clear_bit(1, &wdt_status);
It'd be nice to enumerate the bits in wdt_status.
> +
> + case WDIOC_SETTIMEOUT:
> + ret = get_user(time, (int *)arg);
> + if (ret)
> + break;
> +
> + if (time <= 0 || time > 60) {
> + ret = -EINVAL;
> + break;
> + }
> +
> + heartbeat = time;
> + wdt_enable();
Missing a break here?
> + case WDIOC_GETTIMEOUT:
> + ret = put_user(heartbeat, (int *)arg);
> + break;
> +
> + case WDIOC_KEEPALIVE:
> + wdt_enable();
> + ret = 0;
> + break;
> + }
> + return ret;
next prev parent reply other threads:[~2004-05-11 21:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-11 21:22 Deepak Saxena
2004-05-11 21:33 ` Andrew Morton [this message]
2004-05-11 21:50 ` Deepak Saxena
2004-05-11 22:37 ` Jeff Garzik
2004-05-11 22:48 ` Marc Singer
2004-05-11 23:02 ` Deepak Saxena
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040511143352.096bc071.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=dsaxena@plexity.net \
--cc=linux-kernel@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®