mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH} H8/300 update (2/9) ldscripts fix
Date: Tue, 11 May 2004 17:51:05 -0700	[thread overview]
Message-ID: <20040511175105.7d669535.akpm@osdl.org> (raw)
In-Reply-To: <m2zn8erkdv.wl%ysato@users.sourceforge.jp>

Yoshinori Sato <ysato@users.sourceforge.jp> wrote:
>
> +#if defined(CONFIG_H8300) || defined(CONFIG_V850)
> +#define SYMBOL(_sym_) _##_sym_
> +#else
> +#define SYMBOL(_sym_) _sym_
> +#endif
> +

Adding arch-specific stuff to an include/asm-generic/ header file is
not nice.

However, having to create an arch-specific version of the header
just becasue you need this wrapper is also not nice.

And "SYMBOL" is a too generic identifier: it may clash with other things.


Could I suggest that you change asm-generic/vmlinux.lds.h to do:

#ifndef VMLINUX_SYMBOL
#define VMLINUX_SYMBOL(_sym_) _sym_
#endif

	...

-		__start___ksymtab = .;					\
+		VMLINUX_SYMBOL(__start___ksymtab) = .;			\


Then, in some h8300-specific file, do:

	#define VMLINUX_SYMBOL(_sym_) _##_sym_
	#include <asm-generic/vmlinux.lds.h>

and include that file instead of asm-generic/vmlinux.lds.h?

(I am unable to find where h8300 actually includes vmlinux.lds.h. 
Confused).


  parent reply	other threads:[~2004-05-12  0:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-11 16:36 Yoshinori Sato
2004-05-12  0:10 ` Andrew Morton
2004-05-12  0:51 ` Andrew Morton [this message]
2004-05-12 14:19   ` Yoshinori Sato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040511175105.7d669535.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®