On May 11 2004, at 14:33, Andrew Morton was caught saying:
> Deepak Saxena <dsaxena@plexity.net> wrote:
> >
> > 
> > Following patch against 2.6.6 adds a driver for the watchdogs on the
> > Intel IXP4xx family of network processors (ARM). Please apply.
> > 
> > ...
> > +
> > +	clear_bit(1, &wdt_status);
> 
> It'd be nice to enumerate the bits in wdt_status.

Added #define of the bit meaning. I just copied and pasted from
other wdt drivers. :)

> > +	case WDIOC_SETTIMEOUT:
> > +		ret = get_user(time, (int *)arg);
> > +		if (ret)
> > +			break;
> > +
> > +		if (time <= 0 || time > 60) {
> > +			ret = -EINVAL;
> > +			break;
> > +		}
> > +
> > +		heartbeat = time;
> > +		wdt_enable();
> 
> Missing a break here?

Nope. The SETTIMEOUT case fallsthrough to the GETTIMEOT and returns
the actual timeout value. Added a comment like in other drivers
stating that it falls through.

Updated patch attached.

~Deepak

-- 
Deepak Saxena - dsaxena at plexity dot net - http://www.plexity.net/

"Unlike me, many of you have accepted the situation of your imprisonment and
 will die here like rotten cabbages." - Number 6