From: Vojtech Pavlik <vojtech@suse.cz>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: linux-kernel@vger.kernel.org, davem@redhat.com
Subject: Re: Why pass pt_regs throughout the input system?
Date: Wed, 12 May 2004 10:40:56 +0200 [thread overview]
Message-ID: <20040512084056.GB301@ucw.cz> (raw)
In-Reply-To: <200405112304.50413.dtor_core@ameritech.net>
On Tue, May 11, 2004 at 11:04:50PM -0500, Dmitry Torokhov wrote:
> I have a question - why do we have to pass pt_regs structure throughout
> entire input system? As far as I can tell it is a snapshot of all registers
> that is done at the keyboard interrupt time and it is not used for anything
> but for displaying this data when requested by SysRq.
>
> Would it be wrong to save it by the hardware driver at interrupt time into a
> structure accessible by keyboard.c? I do not think it matters if the data
> shown by SysRq comes from interrupt other than one that serves keyboard...
>
> Although it is somewhat a domain violation I do not think it is worse than
> fattening interface to pass information that is not needed by most of its
> users.
Ask David S. Miller for details - I think the problem was with
simultaneous invocation of multiple pt_regs printouts.
--
Vojtech Pavlik
SuSE Labs, SuSE CR
next prev parent reply other threads:[~2004-05-12 8:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-12 4:04 Dmitry Torokhov
2004-05-12 8:40 ` Vojtech Pavlik [this message]
2004-05-12 18:15 ` David S. Miller
2004-05-12 18:50 Dmitry Torokhov
2004-05-12 19:10 ` David S. Miller
2004-05-12 20:01 Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040512084056.GB301@ucw.cz \
--to=vojtech@suse.cz \
--cc=davem@redhat.com \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®