From: Adrian Bunk <bunk@fs.tum.de>
To: chessman@tux.org
Cc: tlan-devel@lists.sourceforge.net, jgarzik@pobox.com,
linux-net@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [2.6 patch] fix tlan.c for !PCI
Date: Thu, 13 May 2004 01:51:15 +0200 [thread overview]
Message-ID: <20040512235115.GE21408@fs.tum.de> (raw)
I got the following compile error in 2.6.6-mm1 (but it's not specific to
-mm) with CONFIG_PCI=n:
<-- snip -->
...
CC drivers/net/tlan.o
drivers/net/tlan.c: In function `tlan_remove_one':
drivers/net/tlan.c:449: warning: implicit declaration of function `pci_release_regions'
...
LD .tmp_vmlinux1
drivers/built-in.o(.text+0x135183): In function `tlan_remove_one':
: undefined reference to `pci_release_regions'
drivers/built-in.o(.text+0x13541f): In function `TLan_probe1':
: undefined reference to `pci_release_regions'
make: *** [.tmp_vmlinux1] Error 1
<-- snip -->
The patch below fixes this issue.
Please apply
Adrian
--- linux-2.6.6-mm1-full/drivers/net/tlan.c.old 2004-05-13 01:19:33.000000000 +0200
+++ linux-2.6.6-mm1-full/drivers/net/tlan.c 2004-05-13 01:22:15.000000000 +0200
@@ -446,7 +446,9 @@
pci_free_consistent(priv->pciDev, priv->dmaSize, priv->dmaStorage, priv->dmaStorageDMA );
}
+#ifdef CONFIG_PCI
pci_release_regions(pdev);
+#endif
free_netdev( dev );
@@ -673,8 +675,10 @@
err_out_free_dev:
free_netdev(dev);
err_out_regions:
+#ifdef CONFIG_PCI
if (pdev)
pci_release_regions(pdev);
+#endif
err_out:
if (pdev)
pci_disable_device(pdev);
next reply other threads:[~2004-05-12 23:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-12 23:51 Adrian Bunk [this message]
2004-05-15 19:15 ` [Tlan-devel] " Samuel S Chessman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040512235115.GE21408@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=chessman@tux.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=tlan-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®