mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: Arjan van de Ven <arjanv@redhat.com>, greg@kroah.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] fix aic7xxx_old.c for !PCI
Date: Thu, 13 May 2004 14:36:17 +0200	[thread overview]
Message-ID: <20040513123617.GB22202@fs.tum.de> (raw)
In-Reply-To: <1084434113.2781.6.camel@laptop.fenrus.com>

On Thu, May 13, 2004 at 09:41:53AM +0200, Arjan van de Ven wrote:
> On Thu, 2004-05-13 at 01:55, Adrian Bunk wrote:
> > I got the following compile error in 2.6.6-mm1 (but it's not specific to 
> > -mm) with CONFIG_PCI=n:
> 
> or how about just providing a dummy pci_release_regions() for the !PCI
> case ?

There's no dummy pci_request_regions(), and it might be hard to find a 
return value for a dummy pci_request_regions() that covers all cases.

I'm not religious about this issue, but a dummy pci_release_regions() 
without a dummy pci_request_regions() is a bit asymmetric.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


      reply	other threads:[~2004-05-13 12:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-12 23:55 Adrian Bunk
2004-05-13  7:41 ` Arjan van de Ven
2004-05-13 12:36   ` Adrian Bunk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040513123617.GB22202@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=arjanv@redhat.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®