From: Andrew Morton <akpm@osdl.org>
To: jgarzik@pobox.com, Robert.Picco@hp.com,
linux-kernel@vger.kernel.org, venkatesh.pallipadi@intel.com
Subject: Re: [PATCH] HPET driver
Date: Thu, 13 May 2004 16:46:05 -0700 [thread overview]
Message-ID: <20040513164605.0cd9868e.akpm@osdl.org> (raw)
In-Reply-To: <20040513164226.7efb2a83.akpm@osdl.org>
Andrew Morton <akpm@osdl.org> wrote:
>
> hm, I'm trying to decrypt how the driver accesses the hardware. It's
> taking copies of kernel virtual addresses based off hpet_virt_address, but
> there are no readl's or writel's in there. Is the actual device access
> done over in time_hpet.c?
>
Oh. That's why the volatiles are there.
+static int
+hpet_release (struct inode *inode, struct file *file)
+{
+ struct hpet_dev *devp;
+ volatile struct hpet_timer *timer;
+
+ devp = file->private_data;
+ timer = devp->hd_timer;
+
+ spin_lock_irq(&hpet_lock);
+
+ timer->hpet_config &= ~Tn_INT_ENB_CNF_MASK;
local variable `timer' points at hardware.
Methinks this all should be converted to readl and friends, no?
next prev parent reply other threads:[~2004-05-13 23:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-13 22:34 Robert Picco
2004-05-13 23:17 ` Jeff Garzik
2004-05-13 23:42 ` Andrew Morton
2004-05-13 23:46 ` Andrew Morton [this message]
2004-05-13 23:53 ` HPET docs Jeff Garzik
2004-05-13 23:49 ` [PATCH] HPET driver Jeff Garzik
2004-05-14 11:19 ` Vojtech Pavlik
2004-05-14 16:59 ` Jeff Garzik
2004-05-17 22:33 ` Robert Picco
2004-05-17 22:39 ` Jeff Garzik
2004-05-17 22:43 ` Jeff Garzik
2004-05-17 23:05 ` Andrew Morton
2004-05-17 23:06 ` Jeff Garzik
2004-05-17 23:12 ` Andrew Morton
2004-05-17 23:18 ` Jeff Garzik
2004-05-17 23:25 ` Russell King
2004-05-17 23:41 ` Jeff Garzik
2004-05-17 23:33 ` Andrew Morton
2004-05-17 23:42 ` Jeff Garzik
2004-05-18 1:46 ` Andrew Morton
2004-05-18 1:59 ` Jeff Garzik
[not found] ` <m1vfit3939.fsf_-_@ebiederm.dsl.xmission.com>
[not found] ` <52fz9xpp5l.fsf@topspin.com>
2004-05-18 23:01 ` readq/writeq on 32bit machines Eric W. Biederman
2004-05-19 0:58 ` Roland Dreier
2004-05-19 3:14 ` Eric W. Biederman
[not found] ` <16553.28862.590897.171478@napali.hpl.hp.com>
2004-05-20 2:01 ` [PATCH] HPET driver Jeff Garzik
2004-05-13 23:18 ` Andrew Morton
[not found] <200406181616.i5IGGECd003812@hera.kernel.org>
2004-06-18 20:57 ` Jeff Garzik
2004-06-18 21:55 ` Andrew Morton
2004-06-18 22:45 ` Jeff Garzik
2004-06-23 21:34 ` Robert Picco
2004-06-23 21:41 ` Jeff Garzik
2004-06-23 22:23 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040513164605.0cd9868e.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=Robert.Picco@hp.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome