Re: [PATCH] Powernow-k8 buggy BIOS override for 2.6.6

[Pavel Machek <pavel@ucw.cz>]

Hi!

> > > Following is the updated patch to make the powernow-k8 driver work on 
> > > machines with buggy BIOS, such as emachines m6805.
> > > 
> > > The patch overrides the PST table only if check_pst_table() fails.
> > > 
> > > The minimum value for the override is 800MHz, which is the lowest value 
> > > on all x86_64 systems AFAIK. The max value is the current running value.
> > > 
> > > This patch should be safe to apply, even if Pavel's ACPI table check is
> > > added to the driver. Or does anybody see a problem with it?
> > 
> > Well, there may be problems with that.
> 
> That works good now, see my recent posting to the thread on the cpufreq list
> for more details. I had ACPI processor as module, and that made the
> powernow-k8 ACPI detection to fail. I fixed it with the following little
> patch, attaching it here too for reference.

This patch is okay if you insert modules in right order, but not if
you attempt to insert cpufreq before acpi, right?

Please do not make that go in like it is.
								Pavel


> diff -Nru a/arch/i386/kernel/cpu/cpufreq/powernow-k8.c b/arch/i386/kernel/cpu/cpufreq/powernow-k8.c
> --- a/arch/i386/kernel/cpu/cpufreq/powernow-k8.c	Thu May 13 09:58:24 2004
> +++ b/arch/i386/kernel/cpu/cpufreq/powernow-k8.c	Thu May 13 09:58:24 2004
> @@ -32,7 +32,7 @@
>  #include <asm/io.h>
>  #include <asm/delay.h>
>  
> -#ifdef CONFIG_ACPI_PROCESSOR
> +#if defined(CONFIG_ACPI_PROCESSOR) || defined(CONFIG_ACPI_PROCESSOR_MODULE)
>  #include <linux/acpi.h>
>  #include <acpi/processor.h>
>  #endif

-- 
Horseback riding is like software...
...vgf orggre jura vgf serr.