From: Andrew Morton <akpm@osdl.org>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: torvalds@osdl.org, hugh@veritas.com,
viro@parcelfarce.linux.theplanet.co.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RFC] truncate vs add_to_page_cache race
Date: Fri, 14 May 2004 16:50:38 -0700 [thread overview]
Message-ID: <20040514165038.17eb142b.akpm@osdl.org> (raw)
In-Reply-To: <40A55647.8020904@yahoo.com.au>
Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
> I think the entire problem can be fixed by ensuring ->readpage and
> do_generic_mapping read see the same i_size. This would either mean
> passing i_size to or from ->readpage, *or* having ->readpage return
> the number of bytes read, for example.
Or not check i_size in ->readpage at all?
If fixing this is going to cost extra fastpath cycles I'd be inclined to
not bother, frankly.
next prev parent reply other threads:[~2004-05-14 23:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-14 2:01 Nick Piggin
2004-05-14 2:20 ` Nick Piggin
2004-05-14 2:33 ` Andrew Morton
2004-05-14 2:39 ` Nick Piggin
2004-05-14 3:10 ` Nick Piggin
2004-05-14 3:15 ` Nick Piggin
2004-05-14 23:29 ` Nick Piggin
2004-05-14 23:50 ` Andrew Morton [this message]
2004-05-15 0:09 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040514165038.17eb142b.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=torvalds@osdl.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®