From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Henrik.Seidel@gmx.de
Subject: Re: sysfs warning + spinlock BUG in typhoon radio
Date: Fri, 14 May 2004 17:11:38 -0700 [thread overview]
Message-ID: <20040514171138.0b99bb6c.rddunlap@osdl.org> (raw)
In-Reply-To: <20040514162919.143c0d6c.akpm@osdl.org>
On Fri, 14 May 2004 16:29:19 -0700 Andrew Morton wrote:
| "Randy.Dunlap" <rddunlap@osdl.org> wrote:
| >
| > Calling initcall 0xc10bc558: typhoon_init+0x0/0x12a()
| > Typhoon Radio Card driver v0.1
| > CLASS: registering class device: ID = 'radio2'
| > class_hotplug - name = radio2
| > videodev: "Typhoon Radio" has no release callback. Please fix your driver for proper sysfs support, see http://lwn.net/Articles/36850/
| > radio-typhoon: port 0x316.
| > radio-typhoon: mute frequency is 87500 kHz.
| > eip: c0b946cc
| > ------------[ cut here ]------------
| > kernel BUG at include/asm/spinlock.h:120!
|
| Does this fix?
|
|
| diff -puN drivers/media/radio/radio-typhoon.c~typhoon-locking-fix drivers/media/radio/radio-typhoon.c
| --- 25/drivers/media/radio/radio-typhoon.c~typhoon-locking-fix Fri May 14 16:26:46 2004
| +++ 25-akpm/drivers/media/radio/radio-typhoon.c Fri May 14 16:28:29 2004
| @@ -326,7 +326,6 @@ static int __init typhoon_init(void)
| return -EINVAL;
| }
| typhoon_unit.iobase = io;
| - init_MUTEX(&typhoon_unit.lock);
|
| if (mutefreq < 87000 || mutefreq > 108500) {
| printk(KERN_ERR "radio-typhoon: You must set a frequency (in kHz) used when muting the card,\n");
| @@ -337,6 +336,7 @@ static int __init typhoon_init(void)
| #endif /* MODULE */
|
| printk(KERN_INFO BANNER);
| + init_MUTEX(&typhoon_unit.lock);
| io = typhoon_unit.iobase;
| if (!request_region(io, 8, "typhoon")) {
| printk(KERN_ERR "radio-typhoon: port 0x%x already in use\n",
|
| _
Yes, that fixes the spinlock BUG. Thanks.
I'll look at the other piece of it later/weekend:
|| videodev: "Typhoon Radio" has no release callback. Please fix your driver for proper sysfs support, see http://lwn.net/Articles/36850/
since this is still there.
--
~Randy
prev parent reply other threads:[~2004-05-15 0:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-14 18:38 Randy.Dunlap
2004-05-14 23:29 ` Andrew Morton
2004-05-15 0:11 ` Randy.Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040514171138.0b99bb6c.rddunlap@osdl.org \
--to=rddunlap@osdl.org \
--cc=Henrik.Seidel@gmx.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®