From: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
To: elf@buici.com, rmk@arm.linux.org.uk
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: arm-lh7a40x IDE support in 2.6.6
Date: Fri, 14 May 2004 18:40:04 +0200 [thread overview]
Message-ID: <200405141840.04401.bzolnier@elka.pw.edu.pl> (raw)
I was just porting my patches killing <asm/arch/ide.h> for
ARM to 2.6.6 when noticed that more work is needed now. :-(
arch/arm/mach-lh7a40x/ide-lpd7a40x.c
include/asm-arm/arch-lh7a40x/ide.h
Why it couldn't be done in drivers/ide/arm
(as discussed on linux-ide)?
Code from <asm/ide.h> is inlined into IDE core code in far too
many interesting places which greatly increasing complexity/insanity
to anybody trying to understand or change it.
The rule is simple:
code outside drivers/ide SHOULDN'T need to know about <linux/ide.h>.
WTF everybody wants to be "smart" and abuses it?
[ and then people complain why IDE is so ugly ]
BTW does it even work as IDE polling code is not merged yet?
Bartlomiej
next reply other threads:[~2004-05-14 16:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-14 16:40 Bartlomiej Zolnierkiewicz [this message]
2004-05-14 16:52 ` Bartlomiej Zolnierkiewicz
2004-05-14 17:28 ` Marc Singer
2004-05-14 17:26 ` Marc Singer
2004-05-14 18:45 ` Bartlomiej Zolnierkiewicz
2004-05-14 19:47 ` Marc Singer
2004-05-14 21:23 ` Bartlomiej Zolnierkiewicz
2004-05-14 21:33 ` Marc Singer
2004-05-14 22:19 ` Bartlomiej Zolnierkiewicz
2004-05-14 22:49 ` Marc Singer
2004-05-14 23:26 ` Bartlomiej Zolnierkiewicz
2004-05-15 0:10 ` Marc Singer
2004-05-15 0:25 ` Bartlomiej Zolnierkiewicz
2004-05-15 0:33 ` Marc Singer
2004-05-14 19:52 ` Russell King
2004-05-14 20:25 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200405141840.04401.bzolnier@elka.pw.edu.pl \
--to=b.zolnierkiewicz@elka.pw.edu.pl \
--cc=elf@buici.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®