mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
To: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Linus Torvalds <torvalds@osdl.org>,
	linux kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] H8/300 IDE support update
Date: Fri, 14 May 2004 21:38:55 +0200	[thread overview]
Message-ID: <200405142138.55928.bzolnier@elka.pw.edu.pl> (raw)
In-Reply-To: <m23c62aof8.wl%ysato@users.sourceforge.jp>

On Friday 14 of May 2004 19:50, Yoshinori Sato wrote:
> At Fri, 14 May 2004 15:07:31 +0200,
>
> Bartlomiej Zolnierkiewicz wrote:
> > On Friday 14 of May 2004 14:39, Yoshinori Sato wrote:
> > > - IDE support update.
> > > - unused memory hole delete.
> >
> > Yoshinori, this patch doesn't apply to vanilla 2.6.6 / 2.6.6-bk1.
> >
> > And once again: please do not use ide_default_{irq,io_base}()
> > and ide_init_hwif_ports() in new IDE code.
>
> Because an address does not continue,
> Cannot set a right address in ide_std_init_ports.

You don't need to use ide_std_init_ports() - it is just a helper
and you shouldn't need ide_init_hwif_ports() et all!

Just add driver to drivers/ide/h8300/ and describe what changes
(not hacks) to the core IDE code you need to make it work (if any).

Cheers.


      reply	other threads:[~2004-05-14 19:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-14 12:39 Yoshinori Sato
2004-05-14 13:07 ` Bartlomiej Zolnierkiewicz
2004-05-14 17:50   ` Yoshinori Sato
2004-05-14 19:38     ` Bartlomiej Zolnierkiewicz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200405142138.55928.bzolnier@elka.pw.edu.pl \
    --to=b.zolnierkiewicz@elka.pw.edu.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®