From: tglx@linutronix.de (Thomas Gleixner)
To: linux-kernel@vger.kernel.org
Subject: [PATCH 2.4.26] drivers/char/vt.c fix compiler warnings
Date: Sat, 15 May 2004 15:05:23 +0200 [thread overview]
Message-ID: <200405151505.23250.tglx@linutronix.de> (raw)
The patch fixes the following warnings, produced by gcc3.3.3:
vt.c: In function `do_kdsk_ioctl':
vt.c:166: warning: comparison is always false due to limited range of data
type
vt.c: In function `do_kdgkb_ioctl':
vt.c:283: warning: comparison is always false due to limited range of data
type
s is a unsigned char, which can never be >= MAX_NR_KEYMAPS, as MAX_NR_KEYMAPS
= 256
tmp.kb_func is an unsigned char, which can never be > MAX_NR_FUNC, which is =
256
Maybe it is neccecary to change the types from unsigned char to uint8_t ?
--
Thomas
________________________________________________________________________
"Free software" is a matter of liberty, not price. To understand the concept,
you should think of "free" as in "free speech,'' not as in "free beer".
________________________________________________________________________
linutronix - competence in embedded & realtime linux
http://www.linutronix.de
mail: tglx@linutronix.de
--- linux-2.4.26.org/drivers/char/vt.c 2002-11-29 00:53:12.000000000 +0100
+++ linux-2.4.26/drivers/char/vt.c 2004-05-15 15:02:05.000000000 +0200
@@ -163,7 +163,7 @@
if (copy_from_user(&tmp, user_kbe, sizeof(struct kbentry)))
return -EFAULT;
- if (i >= NR_KEYS || s >= MAX_NR_KEYMAPS)
+ if (i >= NR_KEYS)
return -EINVAL;
switch (cmd) {
@@ -280,8 +280,6 @@
if (copy_from_user(&tmp, user_kdgkb, sizeof(struct kbsentry)))
return -EFAULT;
tmp.kb_string[sizeof(tmp.kb_string)-1] = '\0';
- if (tmp.kb_func >= MAX_NR_FUNC)
- return -EINVAL;
i = tmp.kb_func;
switch (cmd) {
next reply other threads:[~2004-05-15 13:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-15 13:05 Thomas Gleixner [this message]
2004-05-17 10:47 ` Andries Brouwer
2004-05-17 12:47 ` Thomas Gleixner
2004-05-17 13:36 ` Andries Brouwer
2004-05-17 15:40 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200405151505.23250.tglx@linutronix.de \
--to=tglx@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®