From: Jan Kara <jack@suse.cz>
To: Andrew Morton <akpm@osdl.org>
Cc: Jan Kara <jack@ucw.cz>,
linux-kernel@vger.kernel.org, lukasz@wsisiz.edu.pl,
j.borsboom@erasmusmc.nl, crosser@average.org, torvalds@osdl.org
Subject: Re: [PATCH] Quota fix 2
Date: Mon, 17 May 2004 11:13:34 +0200 [thread overview]
Message-ID: <20040517091334.GC29746@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <20040516000401.506d8456.akpm@osdl.org>
> Jan Kara <jack@ucw.cz> wrote:
> >
> > another fix for quota code - it fixes the problem with recursion into
> > filesystem when inode of quota file needs a page + some other allocation
> > problems.
>
> It makes sense.
>
> > I hope I got the GFP mask setting right..
>
> nope! Here's a fix against your patch.
Originally I had in the patch something similar but then I read the
comment at mapping_set_gfp_mask():
/*
* This is non-atomic. Only to be used before the mapping is activated.
* Probably needs a barrier...
*/
and so changed that to clear_bit(). Anyway thanks for fixing.
Honza
--
Jan Kara <jack@suse.cz>
SuSE CR Labs
prev parent reply other threads:[~2004-05-17 9:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-15 19:28 Jan Kara
2004-05-16 7:04 ` Andrew Morton
2004-05-17 9:13 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040517091334.GC29746@atrey.karlin.mff.cuni.cz \
--to=jack@suse.cz \
--cc=akpm@osdl.org \
--cc=crosser@average.org \
--cc=j.borsboom@erasmusmc.nl \
--cc=jack@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz@wsisiz.edu.pl \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®